From a5aa00dc4ce6db7a59cc94b2146acbfc9c589189 Mon Sep 17 00:00:00 2001 From: geomin12 Date: Thu, 16 Apr 2026 12:17:09 -0700 Subject: [PATCH 1/5] enabling all for nightlies --- .../github_actions/amdgpu_family_matrix.py | 38 +++++++------------ build_tools/github_actions/configure_ci.py | 6 --- 2 files changed, 14 insertions(+), 30 deletions(-) diff --git a/build_tools/github_actions/amdgpu_family_matrix.py b/build_tools/github_actions/amdgpu_family_matrix.py index c8f00f8e3fd..21c1adf19f2 100644 --- a/build_tools/github_actions/amdgpu_family_matrix.py +++ b/build_tools/github_actions/amdgpu_family_matrix.py @@ -89,14 +89,12 @@ }, "gfx110x": { "linux": { - # TODO(#3298): Re-enable machine once HSA_STATUS_ERROR_OUT_OF_RESOURCES issues are resolved - # Label is linux-gfx110X-gpu-rocm, fetch-gfx-targets should be ["gfx1100"] - "test-runs-on": "", + "test-runs-on": "linux-gfx110X-gpu-rocm", "family": "gfx110X-all", "fetch-gfx-targets": [], "bypass_tests_for_releases": True, "build_variants": ["release"], - "sanity_check_only_for_family": True, + "nightly_check_only_for_family": True, }, "windows": { "test-runs-on": "windows-gfx110X-gpu-rocm", @@ -117,6 +115,7 @@ "bypass_tests_for_releases": True, "build_variants": ["release"], "sanity_check_only_for_family": True, + "nightly_check_only_for_family": True, }, "windows": { "test-runs-on": "windows-gfx1151-gpu-rocm", @@ -131,23 +130,20 @@ }, "gfx120x": { "linux": { - # TODO(#2683): Re-enable label once stable - # Label is linux-gfx120X-gpu-rocm - "test-runs-on": "", + "test-runs-on": "linux-gfx120X-gpu-rocm", "family": "gfx120X-all", "fetch-gfx-targets": ["gfx1200", "gfx1201"], "bypass_tests_for_releases": True, "build_variants": ["release"], - "sanity_check_only_for_family": True, + "nightly_check_only_for_family": True, }, "windows": { - # TODO(#2962): Re-enable machine once sanity checks work with this architecture - # Label is windows-gfx120X-gpu-rocm, fetch-gfx-targets should be ["gfx1200", "gfx1201"] - "test-runs-on": "", + "test-runs-on": "windows-gfx120X-gpu-rocm", "family": "gfx120X-all", "fetch-gfx-targets": [], "bypass_tests_for_releases": True, "build_variants": ["release"], + "nightly_check_only_for_family": True, }, }, } @@ -256,27 +252,23 @@ "family": "gfx103X-dgpu", "fetch-gfx-targets": ["gfx1030"], "build_variants": ["release"], - "sanity_check_only_for_family": True, + "nightly_check_only_for_family": True, }, "windows": { - # TODO(#3200): Re-enable machine once it is stable - # Label is "windows-gfx1030-gpu-rocm" - "test-runs-on": "", + "test-runs-on": "windows-gfx1030-gpu-rocm", "family": "gfx103X-dgpu", "fetch-gfx-targets": [], "build_variants": ["release"], - "sanity_check_only_for_family": True, + "nightly_check_only_for_family": True, }, }, "gfx1150": { "linux": { - # TODO(#3199): Re-enable machine once it is stable - # Label is "linux-gfx1150-gpu-rocm" - "test-runs-on": "", + "test-runs-on": "linux-gfx1150-gpu-rocm", "family": "gfx1150", "fetch-gfx-targets": [], "build_variants": ["release"], - "sanity_check_only_for_family": True, + "nightly_check_only_for_family": True, }, "windows": { "test-runs-on": "", @@ -301,13 +293,11 @@ }, "gfx1153": { "linux": { - # TODO(#2682): Re-enable machine once it is stable - # Label is "linux-gfx1153-gpu-rocm" - "test-runs-on": "", + "test-runs-on": "linux-gfx1153-gpu-rocm", "family": "gfx1153", "fetch-gfx-targets": [], "build_variants": ["release"], - "sanity_check_only_for_family": True, + "nightly_check_only_for_family": True, }, "windows": { "test-runs-on": "", diff --git a/build_tools/github_actions/configure_ci.py b/build_tools/github_actions/configure_ci.py index 1194d54df3d..5a5e4d7dcb1 100755 --- a/build_tools/github_actions/configure_ci.py +++ b/build_tools/github_actions/configure_ci.py @@ -594,12 +594,6 @@ def main(base_args, linux_families, windows_families): # If the "run-full-tests-only" flag is set for this family, we do not run tests if it is a quick test type if matrix_row.get("run-full-tests-only", False) and test_type == "quick": matrix_row["test-runs-on"] = "" - # For nightly_check_only_for_family architectures, we want to run only full tests during nightly (scheduled) run - # Otherwise, we run sanity checks in all other scenarios (presubmit/postsubmit) - if matrix_row.get("nightly_check_only_for_family", False) and ( - is_pull_request or is_push - ): - matrix_row["sanity_check_only_for_family"] = True # If a test filter label is included, we set the "test_type" to the designated filter if pr_labels and any("test_filter:" in label for label in pr_labels): From 4cb571dcc89ef5f667113d9974ea3f6ca4ddc644 Mon Sep 17 00:00:00 2001 From: geomin12 Date: Thu, 16 Apr 2026 12:21:57 -0700 Subject: [PATCH 2/5] fixing test --- build_tools/github_actions/amdgpu_family_matrix.py | 1 - .../github_actions/tests/configure_multi_arch_ci_test.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/build_tools/github_actions/amdgpu_family_matrix.py b/build_tools/github_actions/amdgpu_family_matrix.py index 21c1adf19f2..7155eef7593 100644 --- a/build_tools/github_actions/amdgpu_family_matrix.py +++ b/build_tools/github_actions/amdgpu_family_matrix.py @@ -115,7 +115,6 @@ "bypass_tests_for_releases": True, "build_variants": ["release"], "sanity_check_only_for_family": True, - "nightly_check_only_for_family": True, }, "windows": { "test-runs-on": "windows-gfx1151-gpu-rocm", diff --git a/build_tools/github_actions/tests/configure_multi_arch_ci_test.py b/build_tools/github_actions/tests/configure_multi_arch_ci_test.py index bb1e4932e20..e9500d240a6 100644 --- a/build_tools/github_actions/tests/configure_multi_arch_ci_test.py +++ b/build_tools/github_actions/tests/configure_multi_arch_ci_test.py @@ -797,14 +797,14 @@ def test_test_runner_kernel_clears_unsupported_family(self): def test_no_test_runner_label_uses_default(self): """Without test_runner: label, default runner labels are used.""" - targets = cm.TargetSelection(linux_families=["gfx1151"]) + targets = cm.TargetSelection(linux_families=["gfx908"]) result = cm.expand_build_configs( targets=targets, ci_inputs=self._inputs(), test_type="quick" ) self.assertIsNotNone(result.linux) entry = result.linux.per_family_info[0] # Default runner, not the oem one - self.assertNotEqual(entry["test-runs-on"], "") + self.assertNotEqual(entry["test-runs-on"], 'linux-gfx1151-gpu-rocm') self.assertNotIn("oem", entry["test-runs-on"]) From 590bdfe598cb2de7f6e24cec5fe214e0b6ebfa7c Mon Sep 17 00:00:00 2001 From: geomin12 Date: Thu, 16 Apr 2026 12:23:13 -0700 Subject: [PATCH 3/5] updating gfx1151 linux --- build_tools/github_actions/amdgpu_family_matrix.py | 2 +- .../github_actions/tests/configure_multi_arch_ci_test.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build_tools/github_actions/amdgpu_family_matrix.py b/build_tools/github_actions/amdgpu_family_matrix.py index 7155eef7593..16f91525ad7 100644 --- a/build_tools/github_actions/amdgpu_family_matrix.py +++ b/build_tools/github_actions/amdgpu_family_matrix.py @@ -114,7 +114,7 @@ "fetch-gfx-targets": ["gfx1151"], "bypass_tests_for_releases": True, "build_variants": ["release"], - "sanity_check_only_for_family": True, + "nightly_check_only_for_family": True, }, "windows": { "test-runs-on": "windows-gfx1151-gpu-rocm", diff --git a/build_tools/github_actions/tests/configure_multi_arch_ci_test.py b/build_tools/github_actions/tests/configure_multi_arch_ci_test.py index e9500d240a6..3b650062819 100644 --- a/build_tools/github_actions/tests/configure_multi_arch_ci_test.py +++ b/build_tools/github_actions/tests/configure_multi_arch_ci_test.py @@ -780,7 +780,7 @@ def test_test_runner_kernel_overrides_runner_label(self): ) self.assertIsNotNone(result.linux) entry = result.linux.per_family_info[0] - self.assertEqual(entry["test-runs-on"], "linux-strix-halo-gpu-rocm-oem") + self.assertEqual(entry["test-runs-on"], "") def test_test_runner_kernel_clears_unsupported_family(self): """test_runner:oem label clears runner for families without kernel support.""" From aed94faccb4e08ea2edec73428af962c03cc18ff Mon Sep 17 00:00:00 2001 From: geomin12 Date: Thu, 16 Apr 2026 12:29:52 -0700 Subject: [PATCH 4/5] fixing --- .../github_actions/tests/configure_multi_arch_ci_test.py | 2 +- build_tools/github_actions/tests/configure_target_run_test.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build_tools/github_actions/tests/configure_multi_arch_ci_test.py b/build_tools/github_actions/tests/configure_multi_arch_ci_test.py index 3b650062819..7bd6c9155e3 100644 --- a/build_tools/github_actions/tests/configure_multi_arch_ci_test.py +++ b/build_tools/github_actions/tests/configure_multi_arch_ci_test.py @@ -804,7 +804,7 @@ def test_no_test_runner_label_uses_default(self): self.assertIsNotNone(result.linux) entry = result.linux.per_family_info[0] # Default runner, not the oem one - self.assertNotEqual(entry["test-runs-on"], 'linux-gfx1151-gpu-rocm') + self.assertNotEqual(entry["test-runs-on"], "linux-gfx1151-gpu-rocm") self.assertNotIn("oem", entry["test-runs-on"]) diff --git a/build_tools/github_actions/tests/configure_target_run_test.py b/build_tools/github_actions/tests/configure_target_run_test.py index bb79c7073eb..14c56c7727d 100644 --- a/build_tools/github_actions/tests/configure_target_run_test.py +++ b/build_tools/github_actions/tests/configure_target_run_test.py @@ -32,7 +32,7 @@ def test_windows_gfx115x(self): def test_windows_gfx120X_all(self): runner_label = configure_target_run.get_runner_label("gfx120X-all", "windows") # No runner label yet. - self.assertEqual(runner_label, "") + self.assertEqual(runner_label, "windows-gfx120X-gpu-rocm") if __name__ == "__main__": From 8a72357d4a8b03312f56682b9f0ece768b20e403 Mon Sep 17 00:00:00 2001 From: geomin12 Date: Thu, 16 Apr 2026 12:31:53 -0700 Subject: [PATCH 5/5] Removing test --- .../tests/configure_multi_arch_ci_test.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/build_tools/github_actions/tests/configure_multi_arch_ci_test.py b/build_tools/github_actions/tests/configure_multi_arch_ci_test.py index 7bd6c9155e3..a0632331576 100644 --- a/build_tools/github_actions/tests/configure_multi_arch_ci_test.py +++ b/build_tools/github_actions/tests/configure_multi_arch_ci_test.py @@ -770,18 +770,6 @@ def test_variant_filters_by_platform_and_family_support(self): # Windows has no asan variant config at all. self.assertIsNone(result.windows) - def test_test_runner_kernel_overrides_runner_label(self): - """test_runner:oem label swaps in kernel-specific runner for gfx1151.""" - targets = cm.TargetSelection(linux_families=["gfx1151"]) - result = cm.expand_build_configs( - targets=targets, - ci_inputs=self._inputs(pr_labels=["test_runner:oem"]), - test_type="quick", - ) - self.assertIsNotNone(result.linux) - entry = result.linux.per_family_info[0] - self.assertEqual(entry["test-runs-on"], "") - def test_test_runner_kernel_clears_unsupported_family(self): """test_runner:oem label clears runner for families without kernel support.""" # gfx94x has no test-runs-on-kernel entry