From 5c25e5ae9c4ae3a4be18108edd3b348985912bc3 Mon Sep 17 00:00:00 2001 From: mousdahl-amd Date: Thu, 26 Feb 2026 11:50:37 -0800 Subject: [PATCH 1/2] Some small fixes to address PR comments --- .../python/templates/rocm/src/rocm_sdk/tests/devel_test.py | 2 +- .../templates/rocm/src/rocm_sdk/tests/libraries_test.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/devel_test.py b/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/devel_test.py index 3e1e2619b48..d7618e863e9 100644 --- a/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/devel_test.py +++ b/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/devel_test.py @@ -135,7 +135,7 @@ def testSharedLibrariesLoad(self): extra_setup = "" if ( "hipdnn_plugins" in str(so_path) or "test_plugins" in str(so_path) - ) and sys.platform == "win32": + ) and platform.system() == "Windows": # hipdnn plugins have dependencies on other libraries (e.g. miopen). # In a real-world scenario, hipdnn_backend loads these plugins, and # the dependencies are found because they reside in the same directory diff --git a/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py b/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py index fec5cbe1601..e0e510f6462 100644 --- a/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py +++ b/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py @@ -63,7 +63,9 @@ def testSharedLibrariesLoad(self): continue extra_setup = "" - if "hipdnn_plugins" in str(so_path) and sys.platform == "win32": + if ( + "hipdnn_plugins" in str(so_path) or "test_plugins" in str(so_path) + ) and sys.platform.system() == "Windows": # hipdnn plugins have dependencies on other libraries (e.g. miopen). # In a real-world scenario, hipdnn_backend loads these plugins, and # the dependencies are found because they reside in the same directory From fdeac7e287cb2cc1801afb9d82f30cb449daf791 Mon Sep 17 00:00:00 2001 From: mousdahl-amd Date: Fri, 27 Feb 2026 20:06:18 +0000 Subject: [PATCH 2/2] Fixing syntax error in libraries_test.py --- .../python/templates/rocm/src/rocm_sdk/tests/libraries_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py b/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py index e0e510f6462..db8778e439b 100644 --- a/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py +++ b/build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py @@ -5,6 +5,7 @@ import importlib import os from pathlib import Path +import platform import subprocess import sys import sysconfig @@ -65,7 +66,7 @@ def testSharedLibrariesLoad(self): extra_setup = "" if ( "hipdnn_plugins" in str(so_path) or "test_plugins" in str(so_path) - ) and sys.platform.system() == "Windows": + ) and platform.system() == "Windows": # hipdnn plugins have dependencies on other libraries (e.g. miopen). # In a real-world scenario, hipdnn_backend loads these plugins, and # the dependencies are found because they reside in the same directory