From cbd830bb42b199e8a584ec3f517e0c4d9d628c62 Mon Sep 17 00:00:00 2001 From: Laura Promberger Date: Thu, 22 Jan 2026 20:30:15 +0000 Subject: [PATCH 1/4] adjust build_native_linux_packages to run from outside the rock, remove triggering jax workflow. --- .../workflows/build_native_linux_packages.yml | 19 +++++++++++--- .../release_portable_linux_packages.yml | 25 +++---------------- 2 files changed, 20 insertions(+), 24 deletions(-) diff --git a/.github/workflows/build_native_linux_packages.yml b/.github/workflows/build_native_linux_packages.yml index 81172f14616..4f804877062 100644 --- a/.github/workflows/build_native_linux_packages.yml +++ b/.github/workflows/build_native_linux_packages.yml @@ -55,6 +55,12 @@ on: description: The type of release to build ("dev", "nightly", or "prerelease"). All developer-triggered jobs should use "dev"! type: string default: "dev" + repository: + description: "Repository to checkout. Otherwise, defaults to `github.repository`." + type: string + ref: + description: "Branch, tag or SHA to checkout. Defaults to the reference or SHA that triggered the workflow." + type: string permissions: id-token: write @@ -78,10 +84,17 @@ jobs: RELEASE_TYPE: ${{ inputs.release_type || '' }} S3_BUCKET_NATIVE: "therock-${{ inputs.release_type }}-packages" steps: - - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 - - uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0 + - name: "Checking out repository" + uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 + with: + repository: ${{ inputs.repository || github.repository }} + ref: ${{ inputs.ref || '' }} + + - name: Set up Python 3.12 + uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0 with: python-version: '3.12' + - name: Install Python requirements run: | pip install pyelftools boto3 jinja2 @@ -100,7 +113,7 @@ jobs: echo "Fetching artifacts for build ${{ inputs.artifact_run_id }}" python ./build_tools/fetch_artifacts.py \ --run-id=${{ env.ARTIFACT_RUN_ID }} \ - --run-github-repo="ROCm/TheRock" \ + --run-github-repo=${{ inputs.repository || 'ROCm/TheRock' }} \ --artifact-group=${{ inputs.artifact_group }} \ --output-dir=${{ env.ARTIFACTS_DIR }} diff --git a/.github/workflows/release_portable_linux_packages.yml b/.github/workflows/release_portable_linux_packages.yml index 043d566c412..bd9a62138a8 100644 --- a/.github/workflows/release_portable_linux_packages.yml +++ b/.github/workflows/release_portable_linux_packages.yml @@ -329,27 +329,6 @@ jobs: "ref": "${{ inputs.ref || '' }}" } - - name: URL-encode .tar URL - # TODO: Enable JAX wheels for prereleases - if: ${{ env.RELEASE_TYPE != 'prerelease' }} - id: url-encode-tar - run: python -c "from urllib.parse import quote; print('tar_url=${{ needs.setup_metadata.outputs.cloudfront_base_url }}/tarball/' + quote('${{ env.FILE_NAME }}'))" >> ${GITHUB_OUTPUT} - - - name: Trigger build JAX wheels - # TODO: Enable JAX wheels for prereleases - if: ${{ env.RELEASE_TYPE != 'prerelease' && github.repository_owner == 'ROCm' }} - uses: benc-uk/workflow-dispatch@e2e5e9a103e331dad343f381a29e654aea3cf8fc # v1.2.4 - with: - workflow: build_linux_jax_wheels.yml - inputs: | - { "amdgpu_family": "${{ matrix.target_bundle.amdgpu_family }}", - "python_version": "3.12", - "release_type": "${{ env.RELEASE_TYPE }}", - "s3_subdir": "${{ env.S3_STAGING_SUBDIR }}", - "rocm_version": "${{ needs.setup_metadata.outputs.version }}", - "tar_url": "${{ steps.url-encode-tar.outputs.tar_url }}" - } - - name: Trigger build native rpm package if: ${{ github.repository_owner == 'ROCm' }} uses: benc-uk/workflow-dispatch@e2e5e9a103e331dad343f381a29e654aea3cf8fc # v1.2.4 @@ -360,6 +339,8 @@ jobs: "rocm_version": "${{ needs.setup_metadata.outputs.rpm_version }}", "release_type": "${{ env.RELEASE_TYPE }}", "artifact_run_id": "${{ github.run_id }}", + "ref": "${{ inputs.ref || '' }}", + "repository": ${{ inputs.repository || github.repository }}, "native_package_type": "rpm" } @@ -373,6 +354,8 @@ jobs: "rocm_version": "${{ needs.setup_metadata.outputs.deb_version }}", "release_type": "${{ env.RELEASE_TYPE }}", "artifact_run_id": "${{ github.run_id }}", + "ref": "${{ inputs.ref || '' }}", + "repository": ${{ inputs.repository || github.repository }}, "native_package_type": "deb" } From 1da6b02b5ad53dfa19ae231a6f30a60cab20d1fa Mon Sep 17 00:00:00 2001 From: Laura Promberger Date: Fri, 23 Jan 2026 10:16:32 +0000 Subject: [PATCH 2/4] remove unneeded repository for native packging workflow dispatch --- .github/workflows/release_portable_linux_packages.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/release_portable_linux_packages.yml b/.github/workflows/release_portable_linux_packages.yml index bd9a62138a8..54e76fdd44e 100644 --- a/.github/workflows/release_portable_linux_packages.yml +++ b/.github/workflows/release_portable_linux_packages.yml @@ -340,7 +340,6 @@ jobs: "release_type": "${{ env.RELEASE_TYPE }}", "artifact_run_id": "${{ github.run_id }}", "ref": "${{ inputs.ref || '' }}", - "repository": ${{ inputs.repository || github.repository }}, "native_package_type": "rpm" } @@ -355,7 +354,6 @@ jobs: "release_type": "${{ env.RELEASE_TYPE }}", "artifact_run_id": "${{ github.run_id }}", "ref": "${{ inputs.ref || '' }}", - "repository": ${{ inputs.repository || github.repository }}, "native_package_type": "deb" } From 3a699b5499839b256ffca41842e5ef586112ec6e Mon Sep 17 00:00:00 2001 From: Laura Promberger Date: Fri, 23 Jan 2026 12:51:17 +0000 Subject: [PATCH 3/4] change request + readd jax for easier cherrypick --- .../workflows/build_native_linux_packages.yml | 9 +++++--- .../release_portable_linux_packages.yml | 21 +++++++++++++++++++ 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_native_linux_packages.yml b/.github/workflows/build_native_linux_packages.yml index 4f804877062..9cd33af0ad9 100644 --- a/.github/workflows/build_native_linux_packages.yml +++ b/.github/workflows/build_native_linux_packages.yml @@ -27,6 +27,12 @@ on: description: The type of release to build ("dev", "nightly", or "prerelease"). All developer-triggered jobs should use "dev"! required: false type: string + repository: + description: "Repository to checkout. Otherwise, defaults to `github.repository`." + type: string + ref: + description: "Branch, tag or SHA to checkout. Defaults to the reference or SHA that triggered the workflow." + type: string workflow_dispatch: inputs: artifact_group: @@ -55,9 +61,6 @@ on: description: The type of release to build ("dev", "nightly", or "prerelease"). All developer-triggered jobs should use "dev"! type: string default: "dev" - repository: - description: "Repository to checkout. Otherwise, defaults to `github.repository`." - type: string ref: description: "Branch, tag or SHA to checkout. Defaults to the reference or SHA that triggered the workflow." type: string diff --git a/.github/workflows/release_portable_linux_packages.yml b/.github/workflows/release_portable_linux_packages.yml index 54e76fdd44e..d3fbcc7b0c4 100644 --- a/.github/workflows/release_portable_linux_packages.yml +++ b/.github/workflows/release_portable_linux_packages.yml @@ -329,6 +329,27 @@ jobs: "ref": "${{ inputs.ref || '' }}" } + - name: URL-encode .tar URL + # TODO: Enable JAX wheels for prereleases + if: ${{ env.RELEASE_TYPE != 'prerelease' }} + id: url-encode-tar + run: python -c "from urllib.parse import quote; print('tar_url=${{ needs.setup_metadata.outputs.cloudfront_base_url }}/tarball/' + quote('${{ env.FILE_NAME }}'))" >> ${GITHUB_OUTPUT} + + - name: Trigger build JAX wheels + # TODO: Enable JAX wheels for prereleases + if: ${{ env.RELEASE_TYPE != 'prerelease' && github.repository_owner == 'ROCm' }} + uses: benc-uk/workflow-dispatch@e2e5e9a103e331dad343f381a29e654aea3cf8fc # v1.2.4 + with: + workflow: build_linux_jax_wheels.yml + inputs: | + { "amdgpu_family": "${{ matrix.target_bundle.amdgpu_family }}", + "python_version": "3.12", + "release_type": "${{ env.RELEASE_TYPE }}", + "s3_subdir": "${{ env.S3_STAGING_SUBDIR }}", + "rocm_version": "${{ needs.setup_metadata.outputs.version }}", + "tar_url": "${{ steps.url-encode-tar.outputs.tar_url }}" + } + - name: Trigger build native rpm package if: ${{ github.repository_owner == 'ROCm' }} uses: benc-uk/workflow-dispatch@e2e5e9a103e331dad343f381a29e654aea3cf8fc # v1.2.4 From 6697d6dc118145efa92acd912608f21d7eba321b Mon Sep 17 00:00:00 2001 From: Laura Promberger Date: Fri, 23 Jan 2026 13:25:36 +0000 Subject: [PATCH 4/4] nit change request --- .github/workflows/build_native_linux_packages.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_native_linux_packages.yml b/.github/workflows/build_native_linux_packages.yml index 9cd33af0ad9..68c04bfafa4 100644 --- a/.github/workflows/build_native_linux_packages.yml +++ b/.github/workflows/build_native_linux_packages.yml @@ -93,7 +93,7 @@ jobs: repository: ${{ inputs.repository || github.repository }} ref: ${{ inputs.ref || '' }} - - name: Set up Python 3.12 + - name: Set up Python uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0 with: python-version: '3.12' @@ -116,7 +116,7 @@ jobs: echo "Fetching artifacts for build ${{ inputs.artifact_run_id }}" python ./build_tools/fetch_artifacts.py \ --run-id=${{ env.ARTIFACT_RUN_ID }} \ - --run-github-repo=${{ inputs.repository || 'ROCm/TheRock' }} \ + --run-github-repo="ROCm/TheRock" \ --artifact-group=${{ inputs.artifact_group }} \ --output-dir=${{ env.ARTIFACTS_DIR }}