Skip to content

Remove HIPCC_BUILD def, device function bug is fixed in compiler. #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexBrownAMD merged 1 commit into from
Oct 15, 2019
Merged

Remove HIPCC_BUILD def, device function bug is fixed in compiler. #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Tensile/Source/lib/include/Tensile/ContractionProblem.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ namespace Tensile

struct TENSILE_API ContractionInputs: public ProblemInputs
{
HIPCC_BUILD ContractionInputs();
virtual HIPCC_BUILD ~ContractionInputs();
ContractionInputs();
virtual ~ContractionInputs();
};

template <typename A, typename B, typename C, typename D, typename Alpha, typename Beta>
Expand All @@ -247,10 +247,10 @@ namespace Tensile
using AlphaType = Alpha;
using BetaType = Beta;

HIPCC_BUILD TypedContractionInputs();
HIPCC_BUILD TypedContractionInputs(A const* _a, B const* _b, C const* _c, D * _d,
TypedContractionInputs();
TypedContractionInputs(A const* _a, B const* _b, C const* _c, D * _d,
Alpha _alpha, Beta _beta);
HIPCC_BUILD ~TypedContractionInputs();
~TypedContractionInputs();

A const* a = nullptr;
B const* b = nullptr;
Expand Down
6 changes: 0 additions & 6 deletions Tensile/Source/lib/include/Tensile/Macros.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,3 @@
#else
#define TENSILE_API __attribute__ ((visibility("default")))
#endif

#ifdef __HIPCC__
#define HIPCC_BUILD __host__ __device__
#else
#define HIPCC_BUILD
#endif
2 changes: 1 addition & 1 deletion Tensile/Source/lib/include/Tensile/Tensile.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ namespace Tensile
class TENSILE_API ProblemInputs
{
public:
virtual HIPCC_BUILD ~ProblemInputs();
virtual ~ProblemInputs();

};

Expand Down
12 changes: 6 additions & 6 deletions Tensile/Source/lib/source/ContractionProblem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,18 +855,18 @@ namespace Tensile
return stream >> bound.a >> comma >> bound.b;
}

TENSILE_API HIPCC_BUILD ProblemInputs::~ProblemInputs() = default;
HIPCC_BUILD ContractionInputs::ContractionInputs() = default;
HIPCC_BUILD ContractionInputs::~ContractionInputs() = default;
TENSILE_API ProblemInputs::~ProblemInputs() = default;
ContractionInputs::ContractionInputs() = default;
ContractionInputs::~ContractionInputs() = default;

template <typename A, typename B, typename C, typename D, typename Alpha, typename Beta>
HIPCC_BUILD TypedContractionInputs<A, B, C, D, Alpha, Beta>::TypedContractionInputs() = default;
TypedContractionInputs<A, B, C, D, Alpha, Beta>::TypedContractionInputs() = default;

template <typename A, typename B, typename C, typename D, typename Alpha, typename Beta>
HIPCC_BUILD TypedContractionInputs<A, B, C, D, Alpha, Beta>::~TypedContractionInputs() = default;
TypedContractionInputs<A, B, C, D, Alpha, Beta>::~TypedContractionInputs() = default;

template <typename A, typename B, typename C, typename D, typename Alpha, typename Beta>
HIPCC_BUILD TypedContractionInputs<A, B, C, D, Alpha, Beta>::TypedContractionInputs(
TypedContractionInputs<A, B, C, D, Alpha, Beta>::TypedContractionInputs(
A const* _a, B const* _b, C const* _c, D * _d,
Alpha _alpha, Beta _beta)
: a(_a), b(_b), c(_c), d(_d), alpha(_alpha), beta(_beta)
Expand Down