[gfx90a] Winograd f3x2 fp32 support#1158
Merged
Merged
Conversation
Contributor
|
@Slimakanzer test_conv2d has failed because:
It looks familiar ... I'll start the job again. |
This comment has been minimized.
This comment has been minimized.
junliume
approved these changes
Sep 16, 2021
Contributor
|
@junliume I see that you've launched another CI job, so I leave the merging to you. |
Contributor
Yes that one has passed too, will merge asap. Thanks! |
assistant-librarian Bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
[ROCm][Windows] Add missing MIOPEN_INTERNALS_EXPORT to convolution ocl functions (#1158) This PR solves an issue which is same as https://github.com/ROCm/rocm-libraries/pull/877/files#r2261316493 but in different functions. Missing MIOPEN_INTERNALS_EXPORT causes Windows build failure with undefined symbol error, so adding MIOPEN_INTERNALS_EXPORT before functions (just like in this [PR](ROCm/rocm-libraries#1110)) solves the issue. Co-authored-by: BrianHarrisonAMD <169072757+BrianHarrisonAMD@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Winograd f3x2 fp32 support for gfx90a. Partially resolves issue https://github.com/ROCmSoftwarePlatform/MIOpen-internal/issues/2.
Local verification
Test cases