Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocrand/rocrand_xorwow.h used without including /opt/rocm/include #3314

Open
lamb-j opened this issue Oct 14, 2024 · 1 comment
Open

rocrand/rocrand_xorwow.h used without including /opt/rocm/include #3314

lamb-j opened this issue Oct 14, 2024 · 1 comment

Comments

@lamb-j
Copy link

lamb-j commented Oct 14, 2024

#include <rocrand/rocrand_xorwow.h>

Currently, this header file is included inside some MIOpen kernel calls, but the path to this header is not included as a command line include.

In the past, this worked without issues because hipRTC/Comgr automatically added -I /opt/rocm/include to kernel compilations. However, this behavior is being removed, as hipRTC has no guarantees about a system ROCm installation during kernel compilation/execution.

This leads to issues like the following:

In file included from /tmp/comgr-92ff79/input/MIOpenSoftmaxAttn.cpp:38:
/tmp/comgr-92ff79/include/miopen_rocrand.hpp:45:10: fatal error: 'rocrand/rocrand_xorwow.h' file not found
   45 | #include <rocrand/rocrand_xorwow.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated when compiling for gfx1030.

To fix this, MIOpen should include the path to the directory containing rocrand/rocrand_xorwow.h when compiling.

@lamb-j
Copy link
Author

lamb-j commented Nov 12, 2024

Any progress/ideas/thoughts on this one? It is still blocking a major Comgr update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants