You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many of our kernels need to know the target GPU type. Right now we define macros (like MIO_BN_GFX110X) at the host side and pass to the kernel during compilation, via -D options. Therefore, compilation options are changed whenever we introduce support for new GPUs (or deprecate support for the old ones).
🔴 But compilation options are used to build KDB key. Therefore, when we add support for new GPUs, the precompiled binary cache becomes obsolete (and needs to be regenerated!) for currently supported GPUs.
However passing GPU type via options is not required because hip-clang knows the target GPU type, see https://clang.llvm.org/docs/AMDGPUSupport.html. IIRC we already use this approach in the assembly kernels.
Proposal: Remove passing macros from the host code to HIP/OCL compiler. Instead, use the predefined macros provided by hip-clang.
Many of our kernels need to know the target GPU type. Right now we define macros (like
MIO_BN_GFX110X
) at the host side and pass to the kernel during compilation, via-D
options. Therefore, compilation options are changed whenever we introduce support for new GPUs (or deprecate support for the old ones).🔴 But compilation options are used to build KDB key. Therefore, when we add support for new GPUs, the precompiled binary cache becomes obsolete (and needs to be regenerated!) for currently supported GPUs.
However passing GPU type via options is not required because hip-clang knows the target GPU type, see https://clang.llvm.org/docs/AMDGPUSupport.html. IIRC we already use this approach in the assembly kernels.
Proposal: Remove passing macros from the host code to HIP/OCL compiler. Instead, use the predefined macros provided by hip-clang.
Additional info:
[Attribution] @junliume @JehandadKhan @CAHEK7
The text was updated successfully, but these errors were encountered: