Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32: network devices pull in GNRC dependencies statically #12964

Closed
miri64 opened this issue Dec 16, 2019 · 3 comments · Fixed by #12967
Closed

esp32: network devices pull in GNRC dependencies statically #12964

miri64 opened this issue Dec 16, 2019 · 3 comments · Fixed by #12967
Assignees
Labels
Area: drivers Area: Device drivers Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@miri64
Copy link
Member

miri64 commented Dec 16, 2019

Description

While compile testing #12931 we noticed that the ESP32 won't build tests/lwip anymore. The reason: All the device drivers for the SoC network devices pull in GNRC as a static dependency.

Steps to reproduce the issue

Build tests/lwip for an ESP32 board, e.g.

BOARD=esp32-wroom-32 make -C tests/lwip

Expected results

tests/lwip should not pull in any GNRC dependencies.

Actual results

From the build output in current master:

"make" -C /data/riotbuild/riotbase/sys/net/gnrc
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netapi
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netif/hdr
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/netreg
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pkt
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktbuf
"make" -C /data/riotbuild/riotbase/sys/net/gnrc/pktbuf_static

Versions

Current master (50c2a2c)

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: drivers Area: Device drivers labels Dec 16, 2019
@miri64 miri64 added this to the Release 2020.01 milestone Dec 16, 2019
@miri64
Copy link
Member Author

miri64 commented Dec 16, 2019

Ah proposed fix from my side would be to not make the GNRC dependencies static but to put it in their own sub-module, as we did e.g. with xbee, cc110x, etc as well.

@gschorcht
Copy link
Contributor

Yeah, this is already fixed with the code deduplication PR #12955. Since PR#12955 will take some time before it is merged, I will provide a fix for the current master.

@gschorcht
Copy link
Contributor

gschorcht commented Dec 16, 2019

These are simply left overs from the time when I started with the complex building system and wanted to have a working network interface when I compile tests/shell with any network device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants