[DBAAS-974] fix envtest timeout waiting for process kube-apiserver to stop #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchughesiv
requested review from
jeremyary,
xieshenzh,
redhatHameed and
jianrongzhang89
as code owners
tchughesiv
changed the title
… stop Signed-off-by: Tommy Hughes <[email protected]>
xieshenzh
previously approved these changes
Nov 1, 2022
controllers/suite_test.go
Outdated
Comment on lines
167
to
171
| // Set 4 with random | ||
| if err != nil { | ||
| time.Sleep(4 * time.Second) | ||
| } | ||
| err = testEnv.Stop() |
There was a problem hiding this comment.
It looks fine. But I am not sure if the sleep is necessary. The kubebuilder tutorial doesn't have it.
There was a problem hiding this comment.
thanks... fixed it. the real issue was this line -
dbaas-operator/controllers/suite_test.go
Line 157 in 3ff53ed
Signed-off-by: Tommy Hughes <[email protected]>
xieshenzh
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves this issue -
kubernetes-sigs/controller-runtime#1571
resolves hanging processes as well
Signed-off-by: Tommy Hughes [email protected]