Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server not working with Notebook #396

Closed
renkun-ken opened this issue Aug 13, 2020 · 3 comments · Fixed by REditorSupport/vscode-r-lsp#59
Closed

Language server not working with Notebook #396

renkun-ken opened this issue Aug 13, 2020 · 3 comments · Fixed by REditorSupport/vscode-r-lsp#59
Labels

Comments

@renkun-ken
Copy link
Member

As I'm trying to implement the R Notebook using the Notebook API at #394 initiated by #378, I have no clue at the moment how to make language server work when editing R code cells.

The notebook API introduces a new schema vscode-notebook-cell which is not covered by the document selector of the language client created in vscode-r-lsp. I'm not sure if anything has to be changed in languageserver and vscode-r-lsp to handle requests from a notebook or notebook cell.

@andycraig
Copy link
Collaborator

I had a look at that API document and around the VS Code repo but I have no idea either. I'm not even sure if it's possible yet. Is it worth reaching out to the team implementing the Notebook API?

This seems to be a Notebook API 'mega-issue': microsoft/vscode#93265

@renkun-ken
Copy link
Member Author

The language server definitely works with Notebook. See the Jupyter Notebook in preview:

image

Maybe we should take a look at how its language server and client are configured to handle requests from notebook cells.

@renkun-ken
Copy link
Member Author

With some changes made to vscode-r-lsp, the language server now works with the notebook cells.

Kapture 2020-08-26 at 22 57 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants