Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend CamelCase for class names? #465

Closed
hadley opened this issue Oct 16, 2024 · 3 comments · Fixed by #485
Closed

Recommend CamelCase for class names? #465

hadley opened this issue Oct 16, 2024 · 3 comments · Fixed by #485

Comments

@hadley
Copy link
Member

hadley commented Oct 16, 2024

Otherwise when skimming code it's hard to tell the difference between a constructor and a generic.

@t-kalinowski
Copy link
Member

Since we intend for the first letter to be capitalized (so we can still easily distinguish single-word class names), I wonder if we should refer to it as Pascal case (https://en.wikipedia.org/wiki/Camel_case)

@hadley
Copy link
Member Author

hadley commented Nov 4, 2024

IMO camel case is going to be more clear for more users (also I love the file name in that url 😆)

@t-kalinowski
Copy link
Member

We might also want to add a sentence about this recommendation somewhere in the vignettes and in ?new_class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants