From e3a8ebf8eba45731ac938cb2644869643f90f6d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=85=8B=E7=AB=9F?= Date: Thu, 2 Jul 2026 21:14:11 +0800 Subject: [PATCH 1/5] feat(web-shell): add MCP server mentions in @ completion --- .../acp-integration/session/Session.test.ts | 26 ++++ .../src/acp-integration/session/Session.ts | 54 +++++++- packages/cli/src/i18n/locales/en.js | 1 + packages/cli/src/i18n/locales/zh-TW.js | 1 + packages/cli/src/i18n/locales/zh.js | 1 + .../src/ui/hooks/atCommandProcessor.test.ts | 33 +++++ .../cli/src/ui/hooks/atCommandProcessor.ts | 116 +++++++++++++++--- .../cli/src/ui/hooks/useAtCompletion.test.ts | 39 +++++- packages/cli/src/ui/hooks/useAtCompletion.ts | 35 ++++++ packages/cli/src/utils/mcp-server-mention.ts | 63 ++++++++++ .../client/completions/atCompletion.test.ts | 24 +++- .../client/completions/atCompletion.ts | 65 +++++++++- .../client/components/Editor.module.css | 9 +- .../web-shell/client/hooks/useComposerCore.ts | 22 +++- 14 files changed, 452 insertions(+), 37 deletions(-) create mode 100644 packages/cli/src/utils/mcp-server-mention.ts diff --git a/packages/cli/src/acp-integration/session/Session.test.ts b/packages/cli/src/acp-integration/session/Session.test.ts index 2af66114f9c..488897efdf2 100644 --- a/packages/cli/src/acp-integration/session/Session.test.ts +++ b/packages/cli/src/acp-integration/session/Session.test.ts @@ -7399,6 +7399,32 @@ describe('Session', () => { } }); + it('injects MCP server context for @mcp mentions', async () => { + mockConfig.getMcpServers = vi.fn().mockReturnValue({ demo: {} }); + mockConfig.getPromptRegistry = vi.fn().mockReturnValue({ + getPromptsByServer: (name: string) => (name === 'demo' ? ['p'] : []), + }); + mockConfig.getResourceRegistry = vi.fn().mockReturnValue({ + getResourcesByServer: (name: string) => + name === 'demo' ? [{ uri: 'res://1' }] : [], + }); + mockChat.sendMessageStream = vi + .fn() + .mockResolvedValue(createEmptyStream()); + + await session.prompt({ + sessionId: 'test-session-id', + prompt: [{ type: 'text', text: 'Use @mcp:demo now' }], + }); + + const message = firstSentMessage(); + expect(message[0]).toEqual({ text: 'Use @mcp:demo now' }); + const sentText = textParts(message).join('\n'); + expect(sentText).toContain('--- MCP Server: demo ---'); + expect(sentText).toContain('- Resources: 1'); + expect(sentText).toContain('- Prompts: 1'); + }); + it('dedupes repeated extension mentions and skips unknown mentions', async () => { const extension = makeExtension(); mockConfig.getActiveExtensions = vi.fn().mockReturnValue([extension]); diff --git a/packages/cli/src/acp-integration/session/Session.ts b/packages/cli/src/acp-integration/session/Session.ts index 1f887c606f1..3c6cddfc9f7 100644 --- a/packages/cli/src/acp-integration/session/Session.ts +++ b/packages/cli/src/acp-integration/session/Session.ts @@ -177,6 +177,11 @@ import { matchExtensionByRef, parseExtensionRef, } from '../../utils/extension-mention.js'; +import { + buildMcpServerContextText, + matchMcpServerByRef, + parseMcpServerRef, +} from '../../utils/mcp-server-mention.js'; // Import modular session components import type { @@ -686,6 +691,20 @@ function collectExtensionMentionRefs( } } +function collectMcpServerMentionRefs( + text: string, + mentions: Map, +): void { + for (const match of text.matchAll(AT_TOKEN_RE)) { + const pathName = match[1]; + if (!pathName) continue; + const ref = parseMcpServerRef(pathName); + if (ref) { + mentions.set(ref.name.toLowerCase(), ref.name); + } + } +} + export interface AvailableCommandsSnapshot { availableCommands: AvailableCommand[]; availableSkills?: string[]; @@ -5373,6 +5392,7 @@ export class Session implements SessionContext { const embeddedContext: EmbeddedResourceResource[] = []; const extensionMentions = new Map(); + const mcpServerMentions = new Map(); const preserveUnsupportedImageForBridge = shouldRunVisionBridge( this.config, ); @@ -5381,6 +5401,7 @@ export class Session implements SessionContext { switch (part.type) { case 'text': collectExtensionMentionRefs(part.text, extensionMentions); + collectMcpServerMentionRefs(part.text, mcpServerMentions); return { text: part.text }; case 'image': if (preserveUnsupportedImageForBridge) { @@ -5433,18 +5454,21 @@ export class Session implements SessionContext { extensionMentions, abortSignal, ); + const mcpServerParts = + this.#resolveMcpServerMentionParts(mcpServerMentions); if ( atPathCommandParts.length === 0 && embeddedContext.length === 0 && - extensionParts.length === 0 + extensionParts.length === 0 && + mcpServerParts.length === 0 ) { return this.#applyVisionBridgeIfNeeded(parts, abortSignal); } if (atPathCommandParts.length === 0 && embeddedContext.length === 0) { return this.#applyVisionBridgeIfNeeded( - [...parts, ...extensionParts], + [...parts, ...extensionParts, ...mcpServerParts], abortSignal, ); } @@ -5493,6 +5517,7 @@ export class Session implements SessionContext { // Add initial query text first processedQueryParts.push({ text: initialQueryText }); processedQueryParts.push(...extensionParts); + processedQueryParts.push(...mcpServerParts); // Then add content parts (preserving binary files as inlineData) for (const part of contentParts) { @@ -5507,6 +5532,7 @@ export class Session implements SessionContext { } else { processedQueryParts.push({ text: initialQueryText.trim() }); processedQueryParts.push(...extensionParts); + processedQueryParts.push(...mcpServerParts); } // Process embedded context from resource blocks @@ -5650,6 +5676,30 @@ export class Session implements SessionContext { return extensionParts; } + #resolveMcpServerMentionParts( + mcpServerMentions: Map, + ): Part[] { + if (mcpServerMentions.size === 0) return []; + const servers = this.config.getMcpServers?.() ?? {}; + if (Object.keys(servers).length === 0) return []; + + const parts: Part[] = []; + for (const name of mcpServerMentions.values()) { + const matched = matchMcpServerByRef(name, servers); + if (!matched) { + this.debug( + `MCP server "${name}" not found among configured MCP servers. ` + + `Available: ${Object.keys(servers).join(', ') || '(none)'}`, + ); + continue; + } + parts.push({ + text: buildMcpServerContextText(this.config, matched.serverName), + }); + } + return parts; + } + debug(msg: string): void { if (this.config.getDebugMode()) { debugLogger.warn(msg); diff --git a/packages/cli/src/i18n/locales/en.js b/packages/cli/src/i18n/locales/en.js index 4878297dba5..dd5025fc5ad 100644 --- a/packages/cli/src/i18n/locales/en.js +++ b/packages/cli/src/i18n/locales/en.js @@ -1390,6 +1390,7 @@ export default { 'Size:': 'Size:', '{{count}} bytes': '{{count}} bytes', 'Reference in chat': 'Reference in chat', + 'MCP server': 'MCP server', 'MCP resource server': 'MCP resource server', // Invalid tool related translations diff --git a/packages/cli/src/i18n/locales/zh-TW.js b/packages/cli/src/i18n/locales/zh-TW.js index 18c1d42f59f..d3fbe18724b 100644 --- a/packages/cli/src/i18n/locales/zh-TW.js +++ b/packages/cli/src/i18n/locales/zh-TW.js @@ -1225,6 +1225,7 @@ export default { 'Size:': '大小:', '{{count}} bytes': '{{count}} 位元組', 'Reference in chat': '在對話中引用', + 'MCP server': 'MCP 伺服器', 'MCP resource server': 'MCP 資源伺服器', '{{count}} invalid tools': '{{count}} 個無效工具', invalid: '無效', diff --git a/packages/cli/src/i18n/locales/zh.js b/packages/cli/src/i18n/locales/zh.js index d2915433d30..b3096fdef74 100644 --- a/packages/cli/src/i18n/locales/zh.js +++ b/packages/cli/src/i18n/locales/zh.js @@ -1330,6 +1330,7 @@ export default { 'Size:': '大小:', '{{count}} bytes': '{{count}} 字节', 'Reference in chat': '在对话中引用', + 'MCP server': 'MCP 服务器', 'MCP resource server': 'MCP 资源服务器', // Invalid tool related translations diff --git a/packages/cli/src/ui/hooks/atCommandProcessor.test.ts b/packages/cli/src/ui/hooks/atCommandProcessor.test.ts index a8ab13cebb0..f74c27cbe61 100644 --- a/packages/cli/src/ui/hooks/atCommandProcessor.test.ts +++ b/packages/cli/src/ui/hooks/atCommandProcessor.test.ts @@ -67,6 +67,9 @@ describe('handleAtCommand', () => { getPromptRegistry: () => ({ getPromptsByServer: () => [], }), + getResourceRegistry: () => ({ + getResourcesByServer: () => [], + }), getDebugMode: () => false, getFileExclusions: () => ({ getCoreIgnorePatterns: () => COMMON_IGNORE_PATTERNS, @@ -264,6 +267,36 @@ describe('handleAtCommand', () => { ); }); + it('should inject MCP server context for @mcp mentions', async () => { + mockConfig = { + ...mockConfig, + getMcpServers: () => ({ demo: {} }), + getPromptRegistry: () => ({ + getPromptsByServer: (name: string) => (name === 'demo' ? ['p'] : []), + }), + getResourceRegistry: () => ({ + getResourcesByServer: (name: string) => + name === 'demo' ? [{ uri: 'res://1' }] : [], + }), + } as unknown as Config; + + const result = await handleAtCommand({ + query: 'Use @mcp:demo now', + config: mockConfig, + onDebugMessage: mockOnDebugMessage, + messageId: 128, + signal: abortController.signal, + }); + + expect(result.shouldProceed).toBe(true); + expect(result.processedQuery).toEqual([ + { text: 'Use @mcp:demo now' }, + { + text: expect.stringContaining('--- MCP Server: demo ---'), + }, + ]); + }); + it('should handle query with text before and after @command', async () => { const fileContent = 'Markdown content.'; const filePath = await createTestFile( diff --git a/packages/cli/src/ui/hooks/atCommandProcessor.ts b/packages/cli/src/ui/hooks/atCommandProcessor.ts index de27e3dbc1c..8fc7e629786 100644 --- a/packages/cli/src/ui/hooks/atCommandProcessor.ts +++ b/packages/cli/src/ui/hooks/atCommandProcessor.ts @@ -37,6 +37,12 @@ import { EXTENSION_CONTEXT_BUDGET, getExtensionDisplayName, } from '../../utils/extension-mention.js'; +import { + buildMcpServerContextText, + buildMcpServerRef, + matchMcpServerByRef, + parseMcpServerRef, +} from '../../utils/mcp-server-mention.js'; export interface ResolveAtCommandParams { query: string; @@ -214,6 +220,10 @@ export async function resolveAtCommandQuery({ serverName: string; uri: string; }> = []; + const mcpServerMentions: Array<{ + originalAtPath: string; + serverName: string; + }> = []; // Extension references (`@ext:`) collected during the loop. const activeExtensions = config.getActiveExtensions?.() ?? []; @@ -256,6 +266,34 @@ export async function resolveAtCommandQuery({ continue; } + const mcpServerRef = parseMcpServerRef(pathName); + if (mcpServerRef) { + const matched = matchMcpServerByRef( + mcpServerRef.name, + config.getMcpServers() || {}, + ); + if (matched) { + if ( + !mcpServerMentions.some((m) => m.serverName === matched.serverName) + ) { + mcpServerMentions.push({ + originalAtPath, + serverName: matched.serverName, + }); + } + atPathToResolvedSpecMap.set( + originalAtPath, + buildMcpServerRef(matched.serverName), + ); + continue; + } + onDebugMessage( + `MCP server "${mcpServerRef.name}" not found among configured MCP servers. ` + + `Available: ${Object.keys(config.getMcpServers() || {}).join(', ') || '(none)'}`, + ); + continue; + } + // MCP resource reference (`@server:uri`): detected BEFORE filesystem // resolution so a resource URI containing ':' / '//' isn't mistaken for // a path. Only matches when `server` is a configured MCP server; all @@ -487,6 +525,7 @@ export async function resolveAtCommandQuery({ if ( pathSpecsToRead.length === 0 && mcpResourceRefs.length === 0 && + mcpServerMentions.length === 0 && extensionMentions.length === 0 ) { onDebugMessage('No valid file paths found in @ commands to read.'); @@ -511,11 +550,14 @@ export async function resolveAtCommandQuery({ // Aggregate cap across all extensions to prevent unbounded context injection. let extensionContextBudgetRemaining = EXTENSION_CONTEXT_BUDGET; - const extensionParts: Part[] = []; - const extensionDisplays: IndividualToolCallDisplay[] = []; - const extensionLabels: string[] = []; + const scopedMentionEntries: Array<{ + originalAtPath: string; + part: Part; + label: string; + display: IndividualToolCallDisplay; + }> = []; for (let i = 0; i < extensionMentions.length; i++) { - const { extension } = extensionMentions[i]; + const { originalAtPath, extension } = extensionMentions[i]; const displayName = getExtensionDisplayName(extension); const callId = `client-extension-${userMessageTimestamp}-${i}`; @@ -526,18 +568,52 @@ export async function resolveAtCommandQuery({ }); extensionContextBudgetRemaining = context.remainingBudget; - extensionParts.push({ text: context.text }); - extensionLabels.push(buildExtensionRef(extension.name)); - extensionDisplays.push({ - callId, - name: 'Activate Extension', - description: `Activated extension ${displayName}`, - status: ToolCallStatus.Success, - resultDisplay: undefined, - confirmationDetails: undefined, + scopedMentionEntries.push({ + originalAtPath, + part: { text: context.text }, + label: buildExtensionRef(extension.name), + display: { + callId, + name: 'Activate Extension', + description: `Activated extension ${displayName}`, + status: ToolCallStatus.Success, + resultDisplay: undefined, + confirmationDetails: undefined, + }, }); } + for (let i = 0; i < mcpServerMentions.length; i++) { + const { originalAtPath, serverName } = mcpServerMentions[i]; + scopedMentionEntries.push({ + originalAtPath, + part: { text: buildMcpServerContextText(config, serverName) }, + label: buildMcpServerRef(serverName), + display: { + callId: `client-mcp-server-${userMessageTimestamp}-${i}`, + name: 'Activate MCP Server', + description: `Activated MCP server ${serverName}`, + status: ToolCallStatus.Success, + resultDisplay: undefined, + confirmationDetails: undefined, + }, + }); + } + + const scopedMentionOrder = new Map( + atPathCommandParts.map((part, index) => [part.content, index]), + ); + scopedMentionEntries.sort( + (a, b) => + (scopedMentionOrder.get(a.originalAtPath) ?? Number.MAX_SAFE_INTEGER) - + (scopedMentionOrder.get(b.originalAtPath) ?? Number.MAX_SAFE_INTEGER), + ); + const scopedMentionParts = scopedMentionEntries.map((entry) => entry.part); + const scopedMentionLabels = scopedMentionEntries.map((entry) => entry.label); + const scopedMentionDisplays = scopedMentionEntries.map( + (entry) => entry.display, + ); + // Read files (if any). A hard read error aborts the turn, as before — but // any extension/resource tool-cards already gathered are still surfaced. const fileParts: Part[] = []; @@ -588,7 +664,7 @@ export async function resolveAtCommandQuery({ ? errorToolCallDisplay.resultDisplay : undefined; const labelsOnError = [ - ...extensionLabels, + ...scopedMentionLabels, ...contentLabelsForDisplay, ...resourceLabels, ]; @@ -596,7 +672,7 @@ export async function resolveAtCommandQuery({ processedQuery: null, shouldProceed: false, toolDisplays: [ - ...extensionDisplays, + ...scopedMentionDisplays, ...resourceDisplays, errorToolCallDisplay, ], @@ -617,12 +693,12 @@ export async function resolveAtCommandQuery({ // positional alignment, so grouping is safe. const processedQueryParts: PartListUnion = [ { text: initialQueryText }, - ...extensionParts, + ...scopedMentionParts, ...fileParts, ...resourceParts, ]; const allLabels = [ - ...extensionLabels, + ...scopedMentionLabels, ...contentLabelsForDisplay, ...resourceLabels, ]; @@ -630,7 +706,11 @@ export async function resolveAtCommandQuery({ return { processedQuery: processedQueryParts, shouldProceed: true, - toolDisplays: [...extensionDisplays, ...fileDisplays, ...resourceDisplays], + toolDisplays: [ + ...scopedMentionDisplays, + ...fileDisplays, + ...resourceDisplays, + ], filesRead: allLabels, recording: { filesRead: allLabels, diff --git a/packages/cli/src/ui/hooks/useAtCompletion.test.ts b/packages/cli/src/ui/hooks/useAtCompletion.test.ts index 407b5f1e080..40a1c5ce36b 100644 --- a/packages/cli/src/ui/hooks/useAtCompletion.test.ts +++ b/packages/cli/src/ui/hooks/useAtCompletion.test.ts @@ -857,6 +857,35 @@ describe('useAtCompletion', () => { }); }); + describe('MCP server mention completion', () => { + it('suggests @mcp: mentions for @mcp: queries', async () => { + testRootDir = await createTmpDir({ 'file.txt': '' }); + const resourceConfig = { + ...mockConfig, + getMcpServers: () => ({ demo: {}, other: {} }), + } as unknown as Config; + + const { result } = renderHook(() => + useTestHarnessForAtCompletion( + true, + 'mcp:de', + resourceConfig, + testRootDir, + ), + ); + + await waitFor(() => { + expect(result.current.suggestions.length).toBeGreaterThan(0); + }); + expect(result.current.suggestions.map((s) => s.value)).toContain( + 'mcp:demo', + ); + expect(result.current.suggestions.map((s) => s.value)).not.toContain( + 'demo:', + ); + }); + }); + describe('MCP server discovery', () => { it('suggests matching servers (with resources) alongside files for a bare @', async () => { testRootDir = await createTmpDir({ 'my-notes.txt': '' }); @@ -879,14 +908,16 @@ describe('useAtCompletion', () => { expect(result.current.suggestions.length).toBeGreaterThan(0); }); const values = result.current.suggestions.map((s) => s.value); - // Server entry is prepended (before files) and expands to `@myserver:`. - expect(values[0]).toBe('myserver:'); + expect(values[0]).toBe('mcp:myserver'); + expect(values).toContain('myserver:'); expect(values).toContain('my-notes.txt'); + const mentionSug = result.current.suggestions.find( + (s) => s.value === 'mcp:myserver', + ); + expect(mentionSug?.isDirectory).toBe(false); const serverSug = result.current.suggestions.find( (s) => s.value === 'myserver:', ); - // `isDirectory` => no trailing space => completion re-triggers into the - // resource list once `@myserver:` is inserted. expect(serverSug?.isDirectory).toBe(true); }); diff --git a/packages/cli/src/ui/hooks/useAtCompletion.ts b/packages/cli/src/ui/hooks/useAtCompletion.ts index ee27af90919..6851ac03e7b 100644 --- a/packages/cli/src/ui/hooks/useAtCompletion.ts +++ b/packages/cli/src/ui/hooks/useAtCompletion.ts @@ -11,6 +11,7 @@ import type { Suggestion } from '../components/SuggestionsDisplay.js'; import { MAX_SUGGESTIONS_TO_SHOW } from '../components/SuggestionsDisplay.js'; import { matchMcpServerPrefix, buildMcpResourceRef } from './mcpResourceRef.js'; import { getExtensionSuggestions } from './extension-mention-ref.js'; +import { buildMcpServerRef } from '../../utils/mcp-server-mention.js'; import { t } from '../../i18n/index.js'; /** @@ -157,6 +158,35 @@ function getGlobalMcpResourceSuggestions( * straight into that server's resource list (the `getMcpResourceSuggestions` * path above). */ +function getMcpServerMentionSuggestions( + config: Config | undefined, + pattern: string, +): Suggestion[] { + if (!config) return []; + if (config.isTrustedFolder?.() === false) return []; + const mcpServers = config.getMcpServers?.() || {}; + const query = pattern.startsWith('mcp:') + ? pattern.slice('mcp:'.length).toLowerCase() + : pattern.toLowerCase(); + return Object.keys(mcpServers) + .filter((name) => name.toLowerCase().includes(query)) + .sort((a, b) => { + const aLower = a.toLowerCase(); + const bLower = b.toLowerCase(); + const aPrefix = aLower.startsWith(query) ? 0 : 1; + const bPrefix = bLower.startsWith(query) ? 0 : 1; + if (aPrefix !== bPrefix) return aPrefix - bPrefix; + return aLower.localeCompare(bLower); + }) + .map((name) => ({ + label: buildMcpServerRef(name), + value: buildMcpServerRef(name), + description: t('MCP server'), + isDirectory: false, + })) + .slice(0, MAX_SUGGESTIONS_TO_SHOW); +} + function getMcpServerSuggestions( config: Config | undefined, pattern: string, @@ -411,6 +441,10 @@ export function useAtCompletion(props: UseAtCompletionProps): void { // drill in without knowing a URI) AND resources matched globally by // URI/name across all servers. Both computed synchronously and prepended // below. + const mcpServerMentionSuggestions = getMcpServerMentionSuggestions( + config, + state.pattern, + ); const serverSuggestions = getMcpServerSuggestions(config, state.pattern); const globalResourceSuggestions = getGlobalMcpResourceSuggestions( config, @@ -418,6 +452,7 @@ export function useAtCompletion(props: UseAtCompletionProps): void { ); const mcpSuggestions = [ ...extensionSuggestions, + ...mcpServerMentionSuggestions, ...serverSuggestions, ...globalResourceSuggestions, ]; diff --git a/packages/cli/src/utils/mcp-server-mention.ts b/packages/cli/src/utils/mcp-server-mention.ts new file mode 100644 index 00000000000..4cd7c43b69c --- /dev/null +++ b/packages/cli/src/utils/mcp-server-mention.ts @@ -0,0 +1,63 @@ +/** + * @license + * Copyright 2025 Qwen + * SPDX-License-Identifier: Apache-2.0 + */ + +import type { Config, MCPServerConfig } from '@qwen-code/qwen-code-core'; + +export const MCP_SERVER_REF_PREFIX = 'mcp:'; + +export function parseMcpServerRef(pathName: string): { name: string } | null { + if (!pathName.startsWith(MCP_SERVER_REF_PREFIX)) return null; + const name = pathName.slice(MCP_SERVER_REF_PREFIX.length); + if (!name) return null; + return { name }; +} + +export function buildMcpServerRef(serverName: string): string { + return `${MCP_SERVER_REF_PREFIX}${serverName}`; +} + +export function matchMcpServerByRef( + name: string, + servers: Record, +): { serverName: string; server: MCPServerConfig } | undefined { + const lower = name.toLowerCase(); + const matchedName = Object.keys(servers).find( + (serverName) => serverName.toLowerCase() === lower, + ); + if (!matchedName) return undefined; + return { serverName: matchedName, server: servers[matchedName]! }; +} + +export function buildMcpServerContextText( + config: Config, + serverName: string, +): string { + const lines = [ + `--- MCP Server: ${serverName} ---`, + `The user explicitly mentioned this MCP server. Prefer using tools and resources from this server when relevant for this turn. This is advisory context, not a hard restriction.`, + ]; + + const prompts = + config.getPromptRegistry?.()?.getPromptsByServer(serverName) ?? []; + const resources = + config.getResourceRegistry?.()?.getResourcesByServer(serverName) ?? []; + + const details: string[] = []; + if (resources.length > 0) { + details.push(`- Resources: ${resources.length}`); + } + if (prompts.length > 0) { + details.push(`- Prompts: ${prompts.length}`); + } + + if (details.length > 0) { + lines.push('Available capabilities from this MCP server:'); + lines.push(...details); + } + + lines.push(`--- End MCP Server: ${serverName} ---`); + return lines.join('\n'); +} diff --git a/packages/web-shell/client/completions/atCompletion.test.ts b/packages/web-shell/client/completions/atCompletion.test.ts index f2aa747d2d0..d158aba88aa 100644 --- a/packages/web-shell/client/completions/atCompletion.test.ts +++ b/packages/web-shell/client/completions/atCompletion.test.ts @@ -5,6 +5,7 @@ import { atCompletionSource, type ExtensionCompletionEntry, type GlobFn, + type McpServerCompletionEntry, } from './atCompletion'; const extensions: ExtensionCompletionEntry[] = [ @@ -27,6 +28,17 @@ const extensions: ExtensionCompletionEntry[] = [ }, ]; +const mcpServers: McpServerCompletionEntry[] = [ + { + name: 'dataworks', + description: 'DataWorks MCP', + }, + { + name: 'clickhouse', + description: 'ClickHouse MCP', + }, +]; + function context(doc: string): CompletionContext { return new CompletionContext(EditorState.create({ doc }), doc.length, true); } @@ -41,19 +53,22 @@ describe('atCompletionSource', () => { context('@'), () => glob, () => async () => ({ extensions }), + () => async () => ({ servers: mcpServers }), ); expect(result?.from).toBe(0); expect(result?.options.map((option) => option.label)).toEqual([ '@ext:browser', '@ext:review-tools', + '@mcp:clickhouse', + '@mcp:dataworks', '@README.md', '@src/index.ts', ]); expect(glob).toHaveBeenCalledWith('**/*', { maxResults: 50 }); }); - it('filters extensions and files by partial input', async () => { + it('filters extensions, MCP servers, and files by partial input', async () => { const glob = vi.fn().mockResolvedValue({ matches: ['browser-test.ts'], }); @@ -62,10 +77,17 @@ describe('atCompletionSource', () => { context('@bro'), () => glob, () => async () => ({ extensions }), + () => async () => ({ + servers: [ + ...mcpServers, + { name: 'browser-mcp', description: 'Browser MCP' }, + ], + }), ); expect(result?.options.map((option) => option.label)).toEqual([ '@ext:browser', + '@mcp:browser-mcp', '@browser-test.ts', ]); expect(glob).toHaveBeenCalledWith('bro*', { maxResults: 50 }); diff --git a/packages/web-shell/client/completions/atCompletion.ts b/packages/web-shell/client/completions/atCompletion.ts index 697b9384014..dace70e9dad 100644 --- a/packages/web-shell/client/completions/atCompletion.ts +++ b/packages/web-shell/client/completions/atCompletion.ts @@ -15,23 +15,35 @@ export interface ExtensionCompletionEntry { isActive: boolean; } +export interface McpServerCompletionEntry { + name: string; + description?: string; +} + export type LoadExtensionsFn = () => Promise<{ extensions: ExtensionCompletionEntry[]; }>; +export type LoadMcpServersFn = () => Promise<{ + servers: McpServerCompletionEntry[]; +}>; + export function createAtCompletionSource( getGlob: () => GlobFn | undefined, getLoadExtensions: () => LoadExtensionsFn | undefined = () => undefined, + getLoadMcpServers: () => LoadMcpServersFn | undefined = () => undefined, ): ( context: CompletionContext, ) => CompletionResult | null | Promise { - return (context) => atCompletionSource(context, getGlob, getLoadExtensions); + return (context) => + atCompletionSource(context, getGlob, getLoadExtensions, getLoadMcpServers); } export function atCompletionSource( context: CompletionContext, getGlob: () => GlobFn | undefined, getLoadExtensions: () => LoadExtensionsFn | undefined = () => undefined, + getLoadMcpServers: () => LoadMcpServersFn | undefined = () => undefined, ): CompletionResult | null | Promise { const line = context.state.doc.lineAt(context.pos); const textBefore = line.text.slice(0, context.pos - line.from); @@ -42,15 +54,24 @@ export function atCompletionSource( const prefix = match[1]; const atPos = context.pos - match[0].length; const extensionOnly = prefix.startsWith('ext:'); + const mcpOnly = prefix.startsWith('mcp:'); const extensionQuery = extensionOnly ? prefix.slice('ext:'.length) : prefix; - const glob = extensionOnly ? undefined : getGlob(); + const mcpQuery = mcpOnly ? prefix.slice('mcp:'.length) : prefix; + const glob = extensionOnly || mcpOnly ? undefined : getGlob(); const loadExtensions = getLoadExtensions(); + const loadMcpServers = getLoadMcpServers(); return Promise.all([ fetchExtensions(extensionQuery, loadExtensions), + fetchMcpServers(mcpQuery, loadMcpServers), glob ? fetchFiles(prefix, glob) : Promise.resolve([]), - ]).then(([extensions, files]) => { - if (extensions.length === 0 && files.length === 0) return null; + ]).then(([extensions, mcpServers, files]) => { + if ( + extensions.length === 0 && + mcpServers.length === 0 && + files.length === 0 + ) + return null; return { from: atPos, options: [ @@ -62,6 +83,14 @@ export function atCompletionSource( section: 'Extensions', boost: 20, })), + ...mcpServers.map((server) => ({ + label: `@mcp:${server.name}`, + apply: `@mcp:${server.name} `, + detail: server.description, + type: 'keyword', + section: 'MCP Servers', + boost: 18, + })), ...files.map((f) => ({ label: `@${f}`, apply: `@${f} `, @@ -84,6 +113,34 @@ async function fetchFiles(prefix: string, glob: GlobFn): Promise { } } +async function fetchMcpServers( + query: string, + loadMcpServers: LoadMcpServersFn | undefined, +): Promise { + if (!loadMcpServers) return []; + try { + const status = await loadMcpServers(); + const lowerQuery = query.toLowerCase(); + return status.servers + .map((server) => ({ + ...server, + description: sanitizeDisplayText(server.description ?? '') ?? undefined, + })) + .filter((server) => server.name.toLowerCase().includes(lowerQuery)) + .sort((a, b) => { + const aLabel = a.name.toLowerCase(); + const bLabel = b.name.toLowerCase(); + const aPrefix = aLabel.startsWith(lowerQuery) ? 0 : 1; + const bPrefix = bLabel.startsWith(lowerQuery) ? 0 : 1; + if (aPrefix !== bPrefix) return aPrefix - bPrefix; + return aLabel.localeCompare(bLabel); + }) + .slice(0, 50); + } catch { + return []; + } +} + async function fetchExtensions( query: string, loadExtensions: LoadExtensionsFn | undefined, diff --git a/packages/web-shell/client/components/Editor.module.css b/packages/web-shell/client/components/Editor.module.css index 750f0d72c92..7800440ad64 100644 --- a/packages/web-shell/client/components/Editor.module.css +++ b/packages/web-shell/client/components/Editor.module.css @@ -425,9 +425,10 @@ [data-web-shell-tooltip-portal] .cm-tooltip-autocomplete completion-section ) { display: block !important; - height: 0; - margin: 6px 10px 3px; - padding: 0 !important; + height: auto; + margin: 6px 10px 4px; + padding: 2px 0 4px !important; + line-height: 1.2; border-bottom: 1px solid var(--border) !important; } @@ -436,7 +437,7 @@ .cm-tooltip-autocomplete completion-section:first-of-type ) { - display: none !important; + margin-top: 0; } :global( diff --git a/packages/web-shell/client/hooks/useComposerCore.ts b/packages/web-shell/client/hooks/useComposerCore.ts index 8662b958e16..fe71d807c94 100644 --- a/packages/web-shell/client/hooks/useComposerCore.ts +++ b/packages/web-shell/client/hooks/useComposerCore.ts @@ -141,14 +141,15 @@ const TOOLTIP_STYLES = ` [data-web-shell-tooltip-portal] .cm-tooltip-autocomplete completion-section { display: block !important; - height: 0; - margin: 6px 10px 3px; - padding: 0 !important; + height: auto; + margin: 6px 10px 4px; + padding: 2px 0 4px !important; + line-height: 1.2; border-bottom: 1px solid var(--border) !important; } [data-web-shell-tooltip-portal] .cm-tooltip-autocomplete completion-section:first-of-type { - display: none !important; + margin-top: 0; } [data-web-shell-tooltip-portal] .cm-tooltip-autocomplete .cm-completionLabel { @@ -1338,6 +1339,19 @@ export function useComposerCore( createAtCompletionSource( () => workspaceActionsRef.current?.globWorkspace, () => workspaceActionsRef.current?.loadExtensionsStatus, + () => + workspaceActionsRef.current?.loadMcpStatus + ? async () => { + const status = + await workspaceActionsRef.current!.loadMcpStatus(); + return { + servers: (status?.servers ?? []).map((server) => ({ + name: server.name, + description: server.description, + })), + }; + } + : undefined, ), ]; From 01486b8ca66234bf579b3e7cdbae8a650f73b873 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=85=8B=E7=AB=9F?= Date: Fri, 3 Jul 2026 16:47:01 +0800 Subject: [PATCH 2/5] fix(web-shell): polish @ completion groups --- .../client/completions/atCompletion.test.ts | 6 +-- .../client/completions/atCompletion.ts | 51 +++++++++++++++---- .../client/components/Editor.module.css | 2 +- .../web-shell/client/hooks/useComposerCore.ts | 7 ++- packages/web-shell/client/i18n.tsx | 2 +- 5 files changed, 53 insertions(+), 15 deletions(-) diff --git a/packages/web-shell/client/completions/atCompletion.test.ts b/packages/web-shell/client/completions/atCompletion.test.ts index d158aba88aa..ff082870177 100644 --- a/packages/web-shell/client/completions/atCompletion.test.ts +++ b/packages/web-shell/client/completions/atCompletion.test.ts @@ -60,10 +60,10 @@ describe('atCompletionSource', () => { expect(result?.options.map((option) => option.label)).toEqual([ '@ext:browser', '@ext:review-tools', - '@mcp:clickhouse', - '@mcp:dataworks', '@README.md', '@src/index.ts', + '@mcp:clickhouse', + '@mcp:dataworks', ]); expect(glob).toHaveBeenCalledWith('**/*', { maxResults: 50 }); }); @@ -87,8 +87,8 @@ describe('atCompletionSource', () => { expect(result?.options.map((option) => option.label)).toEqual([ '@ext:browser', - '@mcp:browser-mcp', '@browser-test.ts', + '@mcp:browser-mcp', ]); expect(glob).toHaveBeenCalledWith('bro*', { maxResults: 50 }); }); diff --git a/packages/web-shell/client/completions/atCompletion.ts b/packages/web-shell/client/completions/atCompletion.ts index dace70e9dad..82cb69b8b95 100644 --- a/packages/web-shell/client/completions/atCompletion.ts +++ b/packages/web-shell/client/completions/atCompletion.ts @@ -1,6 +1,7 @@ import type { CompletionContext, CompletionResult, + CompletionSection, } from '@codemirror/autocomplete'; export type GlobFn = ( @@ -28,15 +29,36 @@ export type LoadMcpServersFn = () => Promise<{ servers: McpServerCompletionEntry[]; }>; +export interface AtCompletionSectionLabels { + extensions: string; + mcpServers: string; + files: string; +} + +function createSection(name: string, rank: number): CompletionSection { + return { name, rank }; +} + export function createAtCompletionSource( getGlob: () => GlobFn | undefined, getLoadExtensions: () => LoadExtensionsFn | undefined = () => undefined, getLoadMcpServers: () => LoadMcpServersFn | undefined = () => undefined, + sectionLabels: AtCompletionSectionLabels = { + extensions: 'Extensions', + mcpServers: 'MCP Servers', + files: 'Files', + }, ): ( context: CompletionContext, ) => CompletionResult | null | Promise { return (context) => - atCompletionSource(context, getGlob, getLoadExtensions, getLoadMcpServers); + atCompletionSource( + context, + getGlob, + getLoadExtensions, + getLoadMcpServers, + sectionLabels, + ); } export function atCompletionSource( @@ -44,6 +66,11 @@ export function atCompletionSource( getGlob: () => GlobFn | undefined, getLoadExtensions: () => LoadExtensionsFn | undefined = () => undefined, getLoadMcpServers: () => LoadMcpServersFn | undefined = () => undefined, + sectionLabels: AtCompletionSectionLabels = { + extensions: 'Extensions', + mcpServers: 'MCP Servers', + files: 'Files', + }, ): CompletionResult | null | Promise { const line = context.state.doc.lineAt(context.pos); const textBefore = line.text.slice(0, context.pos - line.from); @@ -72,6 +99,12 @@ export function atCompletionSource( files.length === 0 ) return null; + const sections = { + extensions: createSection(sectionLabels.extensions, 0), + files: createSection(sectionLabels.files, 1), + mcpServers: createSection(sectionLabels.mcpServers, 2), + }; + return { from: atPos, options: [ @@ -80,23 +113,23 @@ export function atCompletionSource( apply: `@ext:${ext.name} `, detail: extensionDetail(ext), type: 'keyword', - section: 'Extensions', + section: sections.extensions, boost: 20, })), + ...files.map((f) => ({ + label: `@${f}`, + apply: `@${f} `, + type: 'file', + section: sections.files, + })), ...mcpServers.map((server) => ({ label: `@mcp:${server.name}`, apply: `@mcp:${server.name} `, detail: server.description, type: 'keyword', - section: 'MCP Servers', + section: sections.mcpServers, boost: 18, })), - ...files.map((f) => ({ - label: `@${f}`, - apply: `@${f} `, - type: 'file', - section: 'Files', - })), ], filter: false, }; diff --git a/packages/web-shell/client/components/Editor.module.css b/packages/web-shell/client/components/Editor.module.css index 7800440ad64..1663fbc3981 100644 --- a/packages/web-shell/client/components/Editor.module.css +++ b/packages/web-shell/client/components/Editor.module.css @@ -437,7 +437,7 @@ .cm-tooltip-autocomplete completion-section:first-of-type ) { - margin-top: 0; + margin-top: 6px; } :global( diff --git a/packages/web-shell/client/hooks/useComposerCore.ts b/packages/web-shell/client/hooks/useComposerCore.ts index fe71d807c94..52ae76bae91 100644 --- a/packages/web-shell/client/hooks/useComposerCore.ts +++ b/packages/web-shell/client/hooks/useComposerCore.ts @@ -149,7 +149,7 @@ const TOOLTIP_STYLES = ` } [data-web-shell-tooltip-portal] .cm-tooltip-autocomplete completion-section:first-of-type { - margin-top: 0; + margin-top: 6px; } [data-web-shell-tooltip-portal] .cm-tooltip-autocomplete .cm-completionLabel { @@ -1352,6 +1352,11 @@ export function useComposerCore( }; } : undefined, + { + extensions: t('quickActions.extensions'), + mcpServers: t('mcp.title'), + files: t('editor.hintFiles'), + }, ), ]; diff --git a/packages/web-shell/client/i18n.tsx b/packages/web-shell/client/i18n.tsx index fb34965dcfa..38555d8ad20 100644 --- a/packages/web-shell/client/i18n.tsx +++ b/packages/web-shell/client/i18n.tsx @@ -2008,7 +2008,7 @@ const ZH: Messages = { 'mcp.toolCount': (v) => `${v?.count ?? 0} 个工具`, 'mcp.toolsCount': (v) => `${v?.count ?? 0} 个工具`, 'mcp.toolsLabel': '工具:', - 'mcp.title': 'MCP Servers', + 'mcp.title': 'MCP 服务器', 'mcp.toolDetail': '工具详情', 'mcp.tools': '工具', 'mcp.toolsForServer': (v) => `${v?.name ?? 'Server'} 的工具`, From 850b0aff7a84e25b64a5bd5aad20f058ef89281c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=85=8B=E7=AB=9F?= Date: Fri, 3 Jul 2026 23:02:13 +0800 Subject: [PATCH 3/5] feat(web-shell): add icons for @ references --- .../client/assets/icons/at-extension.svg | 8 ++ .../web-shell/client/assets/icons/at-file.svg | 3 + .../web-shell/client/assets/icons/at-mcp.svg | 3 + .../client/assets/icons/at-skill.svg | 3 + .../client/completions/atCompletion.test.ts | 22 ++-- .../client/completions/atCompletion.ts | 71 +++++++---- .../client/components/ChatEditor.module.css | 23 +++- .../client/components/ChatEditor.tsx | 13 +- .../client/components/composerTagIcons.ts | 18 +++ packages/web-shell/client/customization.tsx | 4 + .../client/hooks/useComposerCore.test.ts | 8 ++ .../web-shell/client/hooks/useComposerCore.ts | 119 ++++++++++++++++-- packages/web-shell/client/i18n.tsx | 4 +- packages/web-shell/client/index.ts | 1 + 14 files changed, 252 insertions(+), 48 deletions(-) create mode 100644 packages/web-shell/client/assets/icons/at-extension.svg create mode 100644 packages/web-shell/client/assets/icons/at-file.svg create mode 100644 packages/web-shell/client/assets/icons/at-mcp.svg create mode 100644 packages/web-shell/client/assets/icons/at-skill.svg create mode 100644 packages/web-shell/client/components/composerTagIcons.ts diff --git a/packages/web-shell/client/assets/icons/at-extension.svg b/packages/web-shell/client/assets/icons/at-extension.svg new file mode 100644 index 00000000000..2f88e163a7e --- /dev/null +++ b/packages/web-shell/client/assets/icons/at-extension.svg @@ -0,0 +1,8 @@ + + + + + + + + diff --git a/packages/web-shell/client/assets/icons/at-file.svg b/packages/web-shell/client/assets/icons/at-file.svg new file mode 100644 index 00000000000..8aae14a36c5 --- /dev/null +++ b/packages/web-shell/client/assets/icons/at-file.svg @@ -0,0 +1,3 @@ + + + diff --git a/packages/web-shell/client/assets/icons/at-mcp.svg b/packages/web-shell/client/assets/icons/at-mcp.svg new file mode 100644 index 00000000000..b0602f9e7b7 --- /dev/null +++ b/packages/web-shell/client/assets/icons/at-mcp.svg @@ -0,0 +1,3 @@ + + + diff --git a/packages/web-shell/client/assets/icons/at-skill.svg b/packages/web-shell/client/assets/icons/at-skill.svg new file mode 100644 index 00000000000..26c0ab22708 --- /dev/null +++ b/packages/web-shell/client/assets/icons/at-skill.svg @@ -0,0 +1,3 @@ + + + diff --git a/packages/web-shell/client/completions/atCompletion.test.ts b/packages/web-shell/client/completions/atCompletion.test.ts index ff082870177..6b411fe564e 100644 --- a/packages/web-shell/client/completions/atCompletion.test.ts +++ b/packages/web-shell/client/completions/atCompletion.test.ts @@ -58,12 +58,12 @@ describe('atCompletionSource', () => { expect(result?.from).toBe(0); expect(result?.options.map((option) => option.label)).toEqual([ - '@ext:browser', - '@ext:review-tools', - '@README.md', - '@src/index.ts', - '@mcp:clickhouse', - '@mcp:dataworks', + 'browser', + 'review-tools', + 'README.md', + 'src/index.ts', + 'clickhouse', + 'dataworks', ]); expect(glob).toHaveBeenCalledWith('**/*', { maxResults: 50 }); }); @@ -86,9 +86,9 @@ describe('atCompletionSource', () => { ); expect(result?.options.map((option) => option.label)).toEqual([ - '@ext:browser', - '@browser-test.ts', - '@mcp:browser-mcp', + 'browser', + 'browser-test.ts', + 'browser-mcp', ]); expect(glob).toHaveBeenCalledWith('bro*', { maxResults: 50 }); }); @@ -105,7 +105,7 @@ describe('atCompletionSource', () => { ); expect(result?.options.map((option) => option.label)).toEqual([ - '@ext:review-tools', + 'review-tools', ]); expect(result?.options[0]?.apply).toBe('@ext:review-tools '); expect(glob).not.toHaveBeenCalled(); @@ -125,7 +125,7 @@ describe('atCompletionSource', () => { ); expect(result?.options.map((option) => option.label)).toEqual([ - '@README.md', + 'README.md', ]); }); }); diff --git a/packages/web-shell/client/completions/atCompletion.ts b/packages/web-shell/client/completions/atCompletion.ts index 82cb69b8b95..a9f3ab26fff 100644 --- a/packages/web-shell/client/completions/atCompletion.ts +++ b/packages/web-shell/client/completions/atCompletion.ts @@ -1,4 +1,5 @@ import type { + Completion, CompletionContext, CompletionResult, CompletionSection, @@ -21,6 +22,12 @@ export interface McpServerCompletionEntry { description?: string; } +export interface AtReferenceCompletion extends Completion { + atReferenceKind?: 'extension' | 'mcp' | 'file'; + atReferenceLabel?: string; + atReferenceValue?: string; +} + export type LoadExtensionsFn = () => Promise<{ extensions: ExtensionCompletionEntry[]; }>; @@ -105,31 +112,51 @@ export function atCompletionSource( mcpServers: createSection(sectionLabels.mcpServers, 2), }; + const bareAt = prefix.length === 0; + const extensionPreview = bareAt ? 4 : extensions.length; + const filePreview = bareAt ? 3 : files.length; + const mcpPreview = bareAt ? 4 : mcpServers.length; + return { from: atPos, options: [ - ...extensions.map((ext) => ({ - label: `@ext:${ext.name}`, - apply: `@ext:${ext.name} `, - detail: extensionDetail(ext), - type: 'keyword', - section: sections.extensions, - boost: 20, - })), - ...files.map((f) => ({ - label: `@${f}`, - apply: `@${f} `, - type: 'file', - section: sections.files, - })), - ...mcpServers.map((server) => ({ - label: `@mcp:${server.name}`, - apply: `@mcp:${server.name} `, - detail: server.description, - type: 'keyword', - section: sections.mcpServers, - boost: 18, - })), + ...extensions.slice(0, extensionPreview).map( + (ext) => + ({ + label: ext.name, + apply: `@ext:${ext.name} `, + detail: extensionDetail(ext), + type: 'keyword', + section: sections.extensions, + boost: 20, + atReferenceKind: 'extension', + atReferenceValue: ext.name, + }) satisfies AtReferenceCompletion, + ), + ...files.slice(0, filePreview).map( + (f) => + ({ + label: f, + apply: `@${f} `, + type: 'file', + section: sections.files, + atReferenceKind: 'file', + atReferenceValue: f, + }) satisfies AtReferenceCompletion, + ), + ...mcpServers.slice(0, mcpPreview).map( + (server) => + ({ + label: server.name, + apply: `@mcp:${server.name} `, + detail: server.description, + type: 'keyword', + section: sections.mcpServers, + boost: 18, + atReferenceKind: 'mcp', + atReferenceValue: server.name, + }) satisfies AtReferenceCompletion, + ), ], filter: false, }; diff --git a/packages/web-shell/client/components/ChatEditor.module.css b/packages/web-shell/client/components/ChatEditor.module.css index 0891125d391..be7ea1992eb 100644 --- a/packages/web-shell/client/components/ChatEditor.module.css +++ b/packages/web-shell/client/components/ChatEditor.module.css @@ -391,6 +391,22 @@ line-height: 1.2; } +.tagLabel, +.tagValue { + color: var(--chat-editor-text-primary); +} + +.tagIcon { + display: block; + width: 12px; + height: 12px; + flex: 0 0 auto; + margin-left: 7px; + background-position: center; + background-repeat: no-repeat; + background-size: contain; +} + .tagLabel, .tagValue { min-width: 0; @@ -404,10 +420,15 @@ color: var(--chat-editor-accent-color); } +.tagIcon + .tagLabel { + padding-left: 0.5ch; +} + .tagValue { max-width: 32ch; padding: 3px 0 3px 0.5ch; - color: var(--chat-editor-text-secondary); + color: var(--foreground, #e4e4e4); + opacity: 1; } .tagRemove { diff --git a/packages/web-shell/client/components/ChatEditor.tsx b/packages/web-shell/client/components/ChatEditor.tsx index 6fa6d13b1de..132ce4e567f 100644 --- a/packages/web-shell/client/components/ChatEditor.tsx +++ b/packages/web-shell/client/components/ChatEditor.tsx @@ -30,6 +30,8 @@ import { getComposerTagLabel, getComposerTagValue, } from '../hooks/useComposerCore'; +import { cssUrlVar } from '../utils/cssUrlVar'; +import { getComposerTagIconUrl } from './composerTagIcons'; import { ModeIcon } from './ModeIcon'; import { getModelDisplayName } from '../utils/modelDisplay'; import { VoiceButton } from '../voice/VoiceButton'; @@ -1240,13 +1242,22 @@ export const ChatEditor = memo( } = core.searchState; const renderComposerTagContent = (tag: WebShellComposerTag) => { - const tagLabel = getComposerTagLabel(tag); + const rawTagLabel = getComposerTagLabel(tag); const tagValue = getComposerTagValue(tag); + const tagLabel = tag.kind ? '' : rawTagLabel; + const iconUrl = getComposerTagIconUrl(tag.kind); if (!tagLabel && !tagValue) { return {tag.id}; } return ( <> + {iconUrl && ( +