From 8a4a31c23ec20bb509c9c419dfe28ba14f9de9c2 Mon Sep 17 00:00:00 2001 From: tt-a1i <53142663+tt-a1i@users.noreply.github.com> Date: Sun, 21 Jun 2026 00:20:28 +0800 Subject: [PATCH] fix(core): reject fractional computer-use integers --- .../core/src/tools/computer-use/tool.test.ts | 17 +++++++++++++++++ packages/core/src/tools/computer-use/tool.ts | 6 +++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/packages/core/src/tools/computer-use/tool.test.ts b/packages/core/src/tools/computer-use/tool.test.ts index abd083275e1..231ec68aace 100644 --- a/packages/core/src/tools/computer-use/tool.test.ts +++ b/packages/core/src/tools/computer-use/tool.test.ts @@ -139,6 +139,7 @@ describe('coerceTypes', () => { properties: { x: { type: 'number' }, y: { type: 'number' }, + element_index: { type: 'integer' }, label: { type: 'string' }, app: { type: 'string' }, }, @@ -153,6 +154,22 @@ describe('coerceTypes', () => { expect(typeof result['y']).toBe('number'); }); + it('coerces integer strings to numbers (schema type: integer)', () => { + const result = coerceTypes({ app: 'X', element_index: '11' }, schema); + expect(result['element_index']).toBe(11); + expect(typeof result['element_index']).toBe('number'); + }); + + it('does not truncate fractional strings for integer fields', () => { + const result = coerceTypes({ app: 'X', element_index: '11.5' }, schema); + expect(result['element_index']).toBe('11.5'); + }); + + it('continues to coerce fractional strings for number fields', () => { + const result = coerceTypes({ app: 'X', x: '11.5' }, schema); + expect(result['x']).toBe(11.5); + }); + // Direction 2: number → string (schema wants string, model sent number) it('coerces integer label to string (schema type: string)', () => { const result = coerceTypes({ app: 'X', label: 11 }, schema); diff --git a/packages/core/src/tools/computer-use/tool.ts b/packages/core/src/tools/computer-use/tool.ts index 313518584ae..b52a7978b26 100644 --- a/packages/core/src/tools/computer-use/tool.ts +++ b/packages/core/src/tools/computer-use/tool.ts @@ -375,7 +375,11 @@ export function coerceTypes( ) { const trimmed = value.trim(); // Only coerce if the string is a clean numeric — don't swallow garbage. - if (/^-?\d+(\.\d+)?$/.test(trimmed)) { + const matchesType = + fieldType === 'integer' + ? /^-?\d+$/.test(trimmed) + : /^-?\d+(\.\d+)?$/.test(trimmed); + if (matchesType) { const parsed = fieldType === 'integer' ? parseInt(trimmed, 10) : parseFloat(trimmed); if (Number.isFinite(parsed)) {