Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache filter requests #2170

Open
hudson-newey opened this issue Nov 18, 2024 · 0 comments
Open

Cache filter requests #2170

hudson-newey opened this issue Nov 18, 2024 · 0 comments
Labels
architecture Architectural changes to the software enhancement New feature or request

Comments

@hudson-newey
Copy link
Member

hudson-newey commented Nov 18, 2024

At the moment we are caching GET and HEAD requests

However, we can improve the performance quite a lot if we start caching filter requests (which are not cached by default because we abuse http semantics to send queries with a POST method and the filter parameters in the body).

  • either using immutable objects with well defined hash protocol for all filters
    bonus wins for structural equality
  • or by controlling serialization ourselves with an interceptor, and then using payload as cache key, or hashing payload. Bonus more control over our serialization protocol (toJSON has been problematic in the past)
@hudson-newey hudson-newey added enhancement New feature or request architecture Architectural changes to the software labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Architectural changes to the software enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant