Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AssociationInjector instances from components #2167

Open
hudson-newey opened this issue Nov 11, 2024 · 0 comments
Open

Remove AssociationInjector instances from components #2167

hudson-newey opened this issue Nov 11, 2024 · 0 comments
Labels
architecture Architectural changes to the software

Comments

@hudson-newey
Copy link
Member

We have a lot of code that creates models inside components.

Because abstract models require an AssociationInjector to use associations, we have historically been using the injector provided by the components constructor.

This is a code smell because most or all of these models should be created through a service that provides the injector when it is created.

We should audit where we are using an AssociationInjector or Injector inside the components and refactor them out to a service if possible.

This problem was originally identified when we strongly typed the AssociationInjector in #2165 (comment)

@hudson-newey hudson-newey added the architecture Architectural changes to the software label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Architectural changes to the software
Projects
None yet
Development

No branches or pull requests

1 participant