Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to sketch out a UI for downloading the results #2011

Open
Tracked by #2008
atruskie opened this issue Nov 25, 2022 · 8 comments · May be fixed by #2016
Open
Tracked by #2008

Start to sketch out a UI for downloading the results #2011

atruskie opened this issue Nov 25, 2022 · 8 comments · May be fixed by #2016
Assignees

Comments

@atruskie
Copy link
Member

No description provided.

@atruskie
Copy link
Member Author

atruskie commented Dec 1, 2022

  • tree structure
  • directories + files
  • similar to harvest items
  • look at old client code for example
  • for files there should be a download button

@hudson-newey
Copy link
Member

I have created a mock-up UI for for a download results page (attached bellow)

image

@atruskie
Copy link
Member Author

atruskie commented Dec 1, 2022

Ok,

So, we're only doing the results download page.

We're not doing the analysis jobs workflow.

There are two types of jobs: default jobs and custom jobs. Default jobs are run automatically by the system. Custom jobs are run by the user.

We're only doing the UI for downloading results from default analyses.

With the above in mind, new specs include:

  • the results component can be mounted in different places
    • to view the results for a custom job (so under /analysis_jobs)
    • to view the results for a default job - this will be mounted under any of the .../audio_recordings routes
  • there should be no option to retry a job
  • and no option to show status of a job (I may change my mind on this later)
  • there are no analysis settings
  • there is no workflow
  • there are no state change modifications
  • there are no stats for the entire job
  • there should be download buttons for the files
  • there should be a WIP download zip button for folders

You did a good job incorporating our design language from harvests, and when we build the analysis job UI we'll likely design an interface that looks like the one you made. But that is not our current task.

Iterate again please.

@hudson-newey
Copy link
Member

Revision:

image

@atruskie
Copy link
Member Author

atruskie commented Dec 2, 2022

Better,

  • buttons should probably be icons by default
  • should not be primary by default (there should be one primary icon visible at a time)
  • i'm not sure what the red counter is for on the folder B ?

@hudson-newey
Copy link
Member

hudson-newey commented Dec 2, 2022

Makes sense, I'll revise using the same icons seen in ...audio_recordings + a zip icon for the folders

@hudson-newey
Copy link
Member

hudson-newey commented Dec 2, 2022

Possible changes:

  • Moving the "Download Results" heading from the table column label to the buttons
    image

  • Give the download icons the "default" colour (dark green in picture bellow) similar to the play button on the audio recordings page
    image

Revised Mock
image

@atruskie
Copy link
Member Author

atruskie commented Dec 2, 2022

Okay, looks good.

We've got enough space in this design that we can move the size tag into its own column.

You can get started on a draft.

@hudson-newey hudson-newey linked a pull request Dec 9, 2022 that will close this issue
7 tasks
@hudson-newey hudson-newey self-assigned this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants