Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load modules #164

Open
Allcharles opened this issue Mar 25, 2020 · 4 comments
Open

Lazy load modules #164

Allcharles opened this issue Mar 25, 2020 · 4 comments
Assignees
@Allcharles
Labels
architecture Architectural changes to the software enhancement New feature or request triage:low Low priority issue or pull request

Comments

@Allcharles
Copy link
Contributor

Update app to support lazy loading of modules. The following modules should not be affected by this change:

  • HomeModule
  • ProjectsModule
  • MyAccountModule
  • ErrorModule
  • SharedModule
  • SecurityModule
@Allcharles Allcharles added enhancement New feature or request architecture Architectural changes to the software triage:low Low priority issue or pull request labels Mar 25, 2020
@Allcharles Allcharles self-assigned this Mar 25, 2020
@atruskie
Copy link
Member

It'd be nice to have an outline of which modules will be factored out into lazy ones.

@Allcharles
Copy link
Contributor Author

Currently, the following will:

  • AboutModule
  • AdminModule
  • DataRequestModule
  • ProfileModule (TheirProfile)
  • ReportProblemModule
  • SendAudioModule
  • StatisticsModule

@atruskie
Copy link
Member

Hmm. Most of those are fairly small modules. There is a tradeoff in lazy loading - the size of module vs speed of load. We should quantify this and use it to make bundling decisions.

@Allcharles
Copy link
Contributor Author

We used to have this: https://alligator.io/angular/angular-webpack-bundle-analyzer/. But I took it out because it never got used. It should help quantify the size of modules, not sure how to verify the speed of load however outside of chrome benchmarking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Allcharles Allcharles

Labels
architecture Architectural changes to the software enhancement New feature or request triage:low Low priority issue or pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atruskie @Allcharles