Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin tag service #169

Merged
merged 6 commits into from
Mar 31, 2020
Merged

Admin tag service #169

merged 6 commits into from
Mar 31, 2020

Conversation

Allcharles
Copy link
Contributor

@Allcharles Allcharles commented Mar 30, 2020 •
edited
Loading

Admin Tag Service

What is the purpose of this PR?

Changes

  • Created generic resolver class
  • Created TagResolvers
  • Populated typeOfTags form select input

Issues

  • No unit tests for tag pages (waited for new method of testing from master branch)
  • No unit tests for TagService (planning to change how the tests are written after all admin pages are completed)

Closes

Closes #132

@Allcharles Allcharles added enhancement New feature or request architecture Architectural changes to the software labels Mar 30, 2020
@Allcharles Allcharles requested a review from atruskie March 30, 2020 05:12
@Allcharles Allcharles mentioned this pull request Mar 30, 2020
Merged
@Allcharles Allcharles linked an issue Mar 30, 2020 that may be closed by this pull request
Admin Tags #132
Open
4 tasks
@Allcharles
Fix tag service endpoint
81dfc0c 
Endpoint was missing /new and /filter extensions to endpoint
@Allcharles Allcharles merged commit ed032c4 into admin-tag-pages Mar 31, 2020
@Allcharles Allcharles deleted the admin-tag-service branch March 31, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atruskie atruskie atruskie approved these changes

Assignees
No one assigned
Labels
architecture Architectural changes to the software enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin Tags
2 participants
@Allcharles @atruskie