Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin tag group pages #171

Merged
merged 7 commits into from
Mar 31, 2020
Merged

Admin tag group pages #171

merged 7 commits into from
Mar 31, 2020

Conversation

Allcharles
Copy link
Contributor

@Allcharles Allcharles commented Mar 30, 2020

Admin Tag Group Pages

Created admin tag group pages (list, new, edit, delete)

Changes

  • Created TagGroupsService
  • Created TagGroup model
  • Created tag group list/forms

Issues

  • Missing tag group list unit tests (because table values aren't set yet)
  • Missing form fields unit tests (because inputs aren't set yet)
  • Missing tag group service unit tests (planning to change how they are written once all admin pages are finished)

Closes

Closes #131

Visual Changes

Tag group list page

image

Tag group new page

image

Tag group edit page

image

Tag group delete page

image

@Allcharles Allcharles added enhancement New feature or request ui feature A new feature/page to add to the project labels Mar 30, 2020
Did not add unit tests to admin tag group list page
@Allcharles Allcharles marked this pull request as ready for review March 30, 2020 08:24
@Allcharles Allcharles requested a review from atruskie March 30, 2020 08:25
Endpoint did not properly handle filter routes
@Allcharles Allcharles merged commit 85a694b into master Mar 31, 2020
@Allcharles Allcharles deleted the admin-tag-group branch March 31, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui feature A new feature/page to add to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Tag Groups
2 participants