Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin scripts #150

Merged
merged 6 commits into from
Mar 11, 2020
Merged

Admin scripts #150

merged 6 commits into from
Mar 11, 2020

Conversation

Allcharles
Copy link
Contributor

Admin Script Pages

Created the admin script pages

Changes

  • Admin Script Page
  • Admin New Script Page
  • ScriptsService

Issues

  • Did not create unit tests for ScriptsService, AdminScriptsComponent, and AdminScriptsNewComponent

Closes

Closes #130

Visual Changes

Admin Scripts Page
image

Admin New Script Page
image

@Allcharles Allcharles added enhancement New feature or request ui feature A new feature/page to add to the project triage:low Low priority issue or pull request labels Mar 10, 2020
@Allcharles Allcharles requested a review from atruskie March 10, 2020 03:44
@Allcharles Allcharles linked an issue Mar 10, 2020 that may be closed by this pull request
Admin Scripts #130
Open
4 tasks
@Allcharles
Copy link
Contributor Author

Forgot to create ScriptsService mock component, create resolvers, and add it to the list of services.

@Allcharles Allcharles added the work in progress Pull request that is currently a WIP label Mar 10, 2020
atruskie
atruskie approved these changes Mar 11, 2020
View reviewed changes
src/app/models/AbstractModel.ts Show resolved Hide resolved
@Allcharles
Added documentation to AbstractModel
2c94432
@Allcharles
Cleanup ScriptService
e2cef07 
- Created ScriptService resolvers
- Removed providedIn: "root" for scriptsservice
- Updated app providers
@Allcharles Allcharles removed the work in progress Pull request that is currently a WIP label Mar 11, 2020
@Allcharles Allcharles merged commit eec0096 into admin-dashboard Mar 11, 2020
@Allcharles Allcharles deleted the admin-scripts branch March 11, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atruskie atruskie atruskie approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request triage:low Low priority issue or pull request ui feature A new feature/page to add to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin Scripts
2 participants
@Allcharles @atruskie