Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single quotes for paths (backtick substitution possible) #674

Open
atruskie opened this issue Apr 8, 2024 · 0 comments
Open

Use single quotes for paths (backtick substitution possible) #674

atruskie opened this issue Apr 8, 2024 · 0 comments

Comments

@atruskie
Copy link
Member

atruskie commented Apr 8, 2024

A malicious path that contains characters that allow for command execution - such a backtick, or dollar operator - could in theory allow for command execution.

This is not possible currently since we never execute our audio tools on user supplied path.

If we use single quotes to wrap paths for our exec code then we can be sure this is never a risk. We currently use double quotes.

We should also test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant