Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created PR Template #305

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Created PR Template #305

merged 2 commits into from
Mar 20, 2020

Conversation

Allcharles
Copy link
Collaborator

Created a PR template to help standardize and improve future PRs.

@Allcharles Allcharles requested a review from atruskie March 20, 2020 02:01
atruskie
atruskie requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@atruskie atruskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little too heavy for a template. Maybe collapse done it the latter sections into the checklist?

Also add checklist item for visual changes?

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@atruskie atruskie merged commit e2df198 into master Mar 20, 2020
@Allcharles Allcharles deleted the pr-template branch March 20, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atruskie atruskie atruskie approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Allcharles @atruskie