Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit terminal on close #24

Open
Allcharles opened this issue Mar 28, 2019 · 1 comment
Open

Exit terminal on close #24

Allcharles opened this issue Mar 28, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Allcharles
Copy link
Collaborator

When closing AP Desktop, if any terminals are active or helpers being used, ask users to confirm before closing. If terminal open, parse CTRL-C command (if possible) to cancel the analysis before closing system.
@Allcharles Allcharles added the bug Something isn't working label Mar 28, 2019
@Allcharles Allcharles self-assigned this Mar 28, 2019
@Allcharles Allcharles added enhancement New feature or request and removed bug Something isn't working labels Jul 9, 2019
@Allcharles
Copy link
Collaborator Author

ChildProcess terminals close automatically when the application is closed by default. Just need to add the warning.

@Allcharles Allcharles removed their assignment Jan 31, 2020
@Allcharles Allcharles added the good first issue Good for newcomers label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Allcharles