Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dealing with empty tool_calls #3514

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: dealing with empty tool_calls #3514

merged 1 commit into from
Dec 10, 2024

Conversation

jacopo-chevallard
Copy link
Collaborator

When streaming the answers, we sometimes receive chunks with empty tool_calls. That was causing messages in previous chunks to be yielded again, so appearing to the user multiple times

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@StanGirard StanGirard merged commit e2f6389 into main Dec 10, 2024
5 checks passed
@StanGirard StanGirard deleted the fix/empty_tool_calls branch December 10, 2024 12:54
StanGirard added a commit that referenced this pull request Dec 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.26](core-0.0.25...core-0.0.26)
(2024-12-10)


### Features

* first version (V0) of the Workflow Management System
([#3493](#3493))
([6450a49](6450a49))


### Bug Fixes

* dealing with empty tool_calls
([#3514](#3514))
([e2f6389](e2f6389))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants