Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behavior in splice syscall #1346

Open
mhomidi opened this issue Aug 20, 2024 · 2 comments
Open

Wrong behavior in splice syscall #1346

mhomidi opened this issue Aug 20, 2024 · 2 comments

Comments

@mhomidi
Copy link
Collaborator

mhomidi commented Aug 20, 2024

Hi all,

Actually I am facing an issue with splice syscall. When I run this testcase, what it expects in line 823 is that splice returns an EINTR. It expects splice gets blocked and receives interrupt generated in line 819. When I checked the code of Quark, it spins in this loop. Actually, it always get EWOULDBLOCK error which is correct but it does not block and get stuck in this loop. So the signal does not work for this thread.

In this testcase, Quark also does not work correctly. the task running this syscall gets blocked in here. I tried to figure out who get this lock but I could not find anything.


Update

Just for second issue, quark lock implementation seems to be wrong. What I am seeing in this implementation, Quark does not care about the task acquiring the lock. In such case, when we a task get a lock, it can not get it again which cause a deadlock in the second testcase. I think we need to have an extra layer on the lock we have now and check it.

@chl337
Copy link
Collaborator

chl337 commented Aug 21, 2024

Just for second issue, quark lock implementation seems to be wrong. What I am seeing in this implementation,

The link above is broken!

@mhomidi
Copy link
Collaborator Author

mhomidi commented Aug 21, 2024

Link is updated now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants