-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcastable Register #139
Comments
why not just let register support broadcast? |
|
directly inherit broadcast will not cause an extra API. We don't want to create so much API, or this will be too noisy and not Julian. Julia types are duck typed, if you implement broadcast then it is broadcast-able, you don't need to create an API for this. |
|
I see. But shouldn't we should provide the batch as multi-process/multi-threaded? rather than a Tuple. Or what's the meaning of a batch. |
Can broadcast support parallelism? Generator seems better than Tuple for a single threading task. |
To return a generator: function broadcastable(reg::DefaultRegister{B}) where B
st = reg |> rank3
(register(view(st, :, :, i)) for i = 1:B)
end But what do you mean for single threaded? better performance? I would prefer BTW, what is |
Cool, thanks for your suggestion. rank3 is the (active, remaining, batch) tensor representation for reg. I can not find a better name. |
They call it I see, then threaded would be better, or you won't want to use batch if this does not have any significant besides sugars. |
Going to support broadcast for batched register, something like this
This realization requrires modifications of intrinsic functions (not shown here).
Any comments?
The text was updated successfully, but these errors were encountered: