Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle de-select when selecting a non-visible object #26

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

martinRenou
Copy link
Member

Selecting a non-visible object in the tree view would not deselect the previously selected object in the 3D view, this PR fixes this use-case.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/handle_select_non_visible

@martinRenou martinRenou changed the title Handle selecting a non-visible object Handle de-select when selecting a non-visible object Nov 7, 2022
@martinRenou martinRenou added the bug Something isn't working label Nov 7, 2022
@trungleduc
Copy link
Member

Thanks @martinRenou

@trungleduc trungleduc merged commit 8308ad5 into jupytercad:main Nov 7, 2022
@martinRenou martinRenou deleted the handle_select_non_visible branch November 7, 2022 14:13
martinRenou added a commit to martinRenou/jupytercad that referenced this pull request Dec 6, 2022
* Handle selecting a non-visible object

* Linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants