Update annotations position on resize #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also improves the window resize performance by not updating the entire react component
martinRenou
added
bug
|
|
trungleduc
reviewed
May 15, 2023
Comment on lines
-1068
to
-1072
| clearTimeout(this._resizeTimeout); | ||
| this._resizeTimeout = setTimeout(() => { | ||
| this.forceUpdate(); | ||
| this._updateAnnotation({ updatePosition: true }); | ||
| }, 500); |
There was a problem hiding this comment.
We don't need debouncing anymore?
There was a problem hiding this comment.
I suppose the debouncing was because forceUpdate was CPU/GPU intensive, but we don't need to call forceUpdate IMO.
The window resize is way smoother with these changes, and it's immediate.
trungleduc
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also improves the window resize performance by not updating the entire react component
Fix #134