Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup selection logic and throttle some events #107

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Cleanup selection logic and throttle some events #107

merged 5 commits into from
Jan 26, 2023

Conversation

martinRenou
Copy link
Member

The main view would always deselect the current selection without checking that it needs to do it, this PR fixes it

@martinRenou martinRenou added the bug Something isn't working label Jan 24, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/cleanup_select

@martinRenou martinRenou marked this pull request as draft January 24, 2023 09:17
@martinRenou martinRenou marked this pull request as ready for review January 25, 2023 11:25
@martinRenou martinRenou changed the title Cleanup selection logic Cleanup selection logic and throttle some events Jan 25, 2023
trungleduc
trungleduc reviewed Jan 25, 2023
View reviewed changes
src/mainview.tsx Outdated Show resolved Hide resolved
hbcarlos
hbcarlos approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou

@hbcarlos
Copy link
Contributor

Can you add jupyter_ydoc==0.2.2 as a dependency here?
That might fix the tests.

@martinRenou
Copy link
Member Author

Thanks Carlos!

@martinRenou martinRenou merged commit 7251238 into jupytercad:main Jan 26, 2023
@martinRenou martinRenou deleted the cleanup_select branch January 26, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc left review comments

@hbcarlos hbcarlos hbcarlos approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @hbcarlos @trungleduc