Revert tic/tac/toc/loop_timer to original defaults - keep only Timer and timeit using global precision

Co-authored-by: mmcky <[email protected]>

Author: Copilot

quantecon/util/tests/test_timing.py

@@ -360,28 +360,27 @@ def test_timer_explicit_precision_overrides_global(self):
         timer = Timer(precision=3, verbose=False)
         assert timer.precision == 3
 
-    def test_tac_toc_use_global_precision(self):
-        """Test that tac/toc functions use global precision by default."""
-        # This is harder to test automatically since it affects output formatting
-        # But we can verify the functions accept None for digits parameter
-        qe.timings.float_precision(6)
-        
+    def test_tac_toc_keep_original_defaults(self):
+        """Test that tac/toc functions maintain original default (digits=2)."""
+        # These functions are deprecated and should maintain original behavior
         tic()
         time.sleep(0.01)
 
-        # These should use global precision (no exception means it works)
-        tac(verbose=False, digits=None)
-        toc(verbose=False, digits=None)
+        # These should use digits=2 by default, not global precision
+        result_tac = tac(verbose=False)  # Uses default digits=2
+        result_toc = toc(verbose=False)  # Uses default digits=2
+        
+        # Just verify they work without error
+        assert result_tac > 0
+        assert result_toc > 0
 
-    def test_loop_timer_uses_global_precision(self):
-        """Test that loop_timer uses global precision by default."""
+    def test_loop_timer_keeps_original_default(self):
+        """Test that loop_timer maintains original default (digits=2)."""
         def test_func():
             time.sleep(0.001)
 
-        qe.timings.float_precision(6)
-        
-        # Should use global precision without error
-        result = loop_timer(2, test_func, digits=None, verbose=False)
+        # Should use digits=2 by default, not global precision
+        result = loop_timer(2, test_func, verbose=False)
         assert len(result) == 2  # Returns (average_time, average_of_best)
 
     def test_timeit_uses_global_precision(self):

quantecon/util/timing.py

@@ -40,7 +40,7 @@ def tic(self):
         self.start = t
         self.last = t
 
-    def tac(self, verbose=True, digits=None):
+    def tac(self, verbose=True, digits=2):
         """
         Return and print elapsed time since last `tic()`, `tac()`, or
         `toc()`.
@@ -50,9 +50,8 @@ def tac(self, verbose=True, digits=None):
         verbose : bool, optional(default=True)
             If True, then prints time.
 
-        digits : scalar(int), optional(default=None)
-            Number of digits printed for time elapsed. If None, uses
-            the global default precision from quantecon.timings.
+        digits : scalar(int), optional(default=2)
+            Number of digits printed for time elapsed.
 
         Returns
         -------
@@ -63,9 +62,6 @@ def tac(self, verbose=True, digits=None):
         if self.start is None:
             raise Exception("tac() without tic()")
 
-        if digits is None:
-            digits = get_default_precision()
-
         t = time.time()
         elapsed = t-self.last
         self.last = t
@@ -78,7 +74,7 @@ def tac(self, verbose=True, digits=None):
 
         return elapsed
 
-    def toc(self, verbose=True, digits=None):
+    def toc(self, verbose=True, digits=2):
         """
         Return and print time elapsed since last `tic()`.
 
@@ -87,9 +83,8 @@ def toc(self, verbose=True, digits=None):
         verbose : bool, optional(default=True)
             If True, then prints time.
 
-        digits : scalar(int), optional(default=None)
-            Number of digits printed for time elapsed. If None, uses
-            the global default precision from quantecon.timings.
+        digits : scalar(int), optional(default=2)
+            Number of digits printed for time elapsed.
 
         Returns
         -------
@@ -100,9 +95,6 @@ def toc(self, verbose=True, digits=None):
         if self.start is None:
             raise Exception("toc() without tic()")
 
-        if digits is None:
-            digits = get_default_precision()
-
         t = time.time()
         self.last = t
         elapsed = t-self.start
@@ -115,7 +107,7 @@ def toc(self, verbose=True, digits=None):
 
         return elapsed
 
-    def loop_timer(self, n, function, args=None, verbose=True, digits=None,
+    def loop_timer(self, n, function, args=None, verbose=True, digits=2,
                    best_of=3):
         """
         Return and print the total and average time elapsed for n runs
@@ -135,9 +127,8 @@ def loop_timer(self, n, function, args=None, verbose=True, digits=None,
         verbose : bool, optional(default=True)
             If True, then prints average time.
 
-        digits : scalar(int), optional(default=None)
-            Number of digits printed for time elapsed. If None, uses
-            the global default precision from quantecon.timings.
+        digits : scalar(int), optional(default=2)
+            Number of digits printed for time elapsed.
 
         best_of : scalar(int), optional(default=3)
             Average time over best_of runs.
@@ -151,9 +142,6 @@ def loop_timer(self, n, function, args=None, verbose=True, digits=None,
             Average of best_of times for n runs of function.
 
         """
-        if digits is None:
-            digits = get_default_precision()
-
         tic()
         all_times = np.empty(n)
         for run in range(n):
@@ -456,15 +444,15 @@ def tic():
     return __timer__.tic()
 
 
-def tac(verbose=True, digits=None):
+def tac(verbose=True, digits=2):
     return __timer__.tac(verbose, digits)
 
 
-def toc(verbose=True, digits=None):
+def toc(verbose=True, digits=2):
     return __timer__.toc(verbose, digits)
 
 
-def loop_timer(n, function, args=None, verbose=True, digits=None, best_of=3):
+def loop_timer(n, function, args=None, verbose=True, digits=2, best_of=3):
     return __timer__.loop_timer(n, function, args, verbose, digits, best_of)