Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov with GitHub Actions #135

Closed
oyamad opened this issue Apr 13, 2021 · 9 comments
Closed

codecov with GitHub Actions #135

oyamad opened this issue Apr 13, 2021 · 9 comments

Comments

@oyamad
Copy link
Member

oyamad commented Apr 13, 2021

Results from codecov are not reported.
Do we need to install Codecov GitHub App to the QuantEcon organization?

@thomasrockhu
Copy link

Tom from Codecov here. @oyamad, I see results here, are there missing commits or that results aren't posted back to PRs?

If that is the problem, I would highly recommend installing the app.

@oyamad
Copy link
Member Author

oyamad commented Apr 13, 2021

@thomasrockhu Thanks for your reply.

If you go to, e.g., this page 8f39f33 and click the red cross mark in front of "Merge pull request #134 from QuantEcon/ci-nightly", you will see a list of "CI-nightly ...", "CI ...", etc, but no codecov report is there.

Compare this page oyamad/MatchingMarkets.jl@37b1469, where there are codecov/patch ... and codecov/project ... entries in the list which shows up by clicking the check mark in front of "Fix badge".

One difference is that the former belongs to the QuantEcon organization, whereas the latter is my own repo. (I never installed Codecov app to my account, though.)

@thomasrockhu
Copy link

Taking a quick look at the first commit, I would really recommend installing the app. We have seen intermittent behavior with users who do not use it and us being able to communicate with GitHub on behalf of the user. Having the app helps us to prevent these issues.

@oyamad
Copy link
Member Author

oyamad commented Apr 14, 2021

App installed, but the situation does not change 9fb6a8c.

@thomasrockhu
Copy link

thomasrockhu commented Apr 20, 2021

@oyamad it looks like the integration was installed, but not for that repository. You can see that in your settings page

@oyamad
Copy link
Member Author

oyamad commented Apr 20, 2021

@thomasrockhu Thanks for the information, but in the settings page, if I click Click here to see your installation listings., then I get Page not found...

@thomasrockhu
Copy link

@oyamad interesting... would you be able to uninstall and re-install the app? I wonder if something weird happened during creation as the link should go to a GitHub hosted page.

@oyamad
Copy link
Member Author

oyamad commented Apr 20, 2021

@thomasrockhu Thanks, I will try that probably tomorrow.

I found this issue ionelmc/python-hunter#86 which seems reporting the same issue.

@oyamad
Copy link
Member Author

oyamad commented Apr 22, 2021

@thomasrockhu App uninstalled and then re-installed, and it now succeeded: coverage is report in PR #136 and codecov entries appear in the list 8fc2518. Thanks!

@oyamad oyamad closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants