Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VPC deployment for GCP via terraform overrides #1259

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Conversation

aktech
Copy link
Member

@aktech aktech commented Apr 22, 2022

Fixes | Closes | Resolves #1211

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Defines terraform override variables to able to deploy in VPC for GCP.

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@magsol magsol added this to the Release v0.4.1 milestone Apr 26, 2022
@costrouc
Copy link
Member

This looks great to me @aktech and I was able to test this out locally

@costrouc costrouc merged commit d1cc49f into main Apr 28, 2022
@costrouc costrouc deleted the gcp-vpc branch April 28, 2022 21:09
@aktech aktech changed the title [WIP] Add support for VPC deployment for GCP via terraform overrides Add support for VPC deployment for GCP via terraform overrides Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] - Allow for deploying managed kubernetes within VPC for each cloud provider
3 participants