Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge spawner and profile env vars #1237

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Merge spawner and profile env vars #1237

merged 2 commits into from
Apr 7, 2022

Conversation

danlester
Copy link
Contributor

Fixes | Closes | Resolves #1202

Changes introduced in this PR:

  • Merge spawner and profile env vars to ensure dashboard sharing vars are provided to dashboard servers

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@danlester danlester requested a review from iameskild April 7, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants