-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ipython config within jupyterlab to docker image with more robust jupyterlab ssh tests #1143
Conversation
ff746f6
to
69a40f3
Compare
Need to test on a local cluster |
I've made the jupyterhub_ssh tests quite strict to ensure that the user environment it setup properly. Make take a few tries to get all the tests passing. I also changed the test username to be a complex example to test how jupyterlab handles this |
Hi @costrouc I will add this to v0.4.x milestone, is it okay for you? |
This PR passes on the cloud tests as well https://github.com/Quansight/qhub-integration-test/runs/5452337353?check_suite_focus=true |
6f41de7
to
03b7b72
Compare
@viniciusdc this would be ready for review now that 0.4 has been released |
I will review it thanks @costrouc, as I will deploy it to test the PS1 features and check the configmaps directly, I should finish it by next Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I was able to check all configmaps were present and working. The skel configs were propagated and I was able to validate the pytests as well.
...late/stages/07-kubernetes-services/modules/kubernetes/services/jupyterhub/files/skel/.bashrc
Show resolved
Hide resolved
I updated to the latest in main and if that passes I will merge. |
Closes #1157
This PR serves a few purposes. All with the goal of making the docker images simpler (only has installed packages not configuration).