Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doing a new release including type annotations? #276

Closed
rgommers opened this issue Jul 6, 2022 · 7 comments
Closed

doing a new release including type annotations? #276

rgommers opened this issue Jul 6, 2022 · 7 comments

Comments

@rgommers
Copy link
Member

rgommers commented Jul 6, 2022

@hameerabbasi a release would be helpful to be able to make the new type annotations available. WDYT?

I had a look at the release process, but it's not documented. Based on the GHA file, it may be a matter of:

  1. Push a tag 0.9.0
  2. Wait till build_wheel is finished, download the artifacts locally, and then upload them to PyPI with twine

Is there anything more to it?

@BvB93
Copy link
Contributor

BvB93 commented Jul 6, 2022

So the type annotations aren't quite finished yet, as they're only fully implemented for the extension module as of now. Whatever is available should be usable downstream though if a partial py.typed file is added.

As for wrapping up the remaining annotations? I don't have time right now, but I was planning to give it a shot next week.

@rgommers
Copy link
Member Author

rgommers commented Jul 6, 2022

thanks @BvB93, that would be great. let's wait till after that is done then.

@hameerabbasi
Copy link
Collaborator

@hameerabbasi a release would be helpful to be able to make the new type annotations available. WDYT?

I had a look at the release process, but it's not documented. Based on the GHA file, it may be a matter of:

  1. Push a tag 0.9.0

  2. Wait till build_wheel is finished, download the artifacts locally, and then upload them to PyPI with twine

Is there anything more to it?

I guess wait for and merge the PR for conda-forge and enabling the tag on RTD, but that should be about it.

@hameerabbasi
Copy link
Collaborator

Just to add: I would also bump the CIBuildWheel version and add macOS universal wheels if possible, also update the supported Python versions. If waiting is feasible I can do this part this weekend.

@rgommers
Copy link
Member Author

rgommers commented Jul 6, 2022

There already are universal2 wheels for macOS, and they work fine.

@hameerabbasi
Copy link
Collaborator

Okay, the Python 3.13rc1 release finally prompted me to push this past the finish line. 0.9.0 should be up on PyPI shortly, uploaded directly using cibuildwheel.

@hameerabbasi
Copy link
Collaborator

0.9.0 somehow didn't want CI to trigger -- 0.9.1 is up on PyPI and conda-forge. I'll make an announcement post soon (tm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants