Focus not always visible on JupyterLab initial page

[gabalafou]

Description

On the initial page in JupyterLab, some elements that receive focus by pressing the tab key do not have a visible focus indicator, which is a violation of WCAG 2.4.7.

This issue is about fixing those focus indicators for the initial page in JupyterLab.

Value / benefit

Understanding WCAG 2.4.7 explains why.

Implementation details

No response

TODO

Beta Give feedback

1. TEST - Write test that verifies that each "tab-able" element on the initial page has a visible focus indicator #199
   area: testing ☑️ type: task ✅ +2
2. Submit PR(s) that make the test pass
3. Focus visible test jupyter-a11y-testing#33
   +0
   

Updates

No response

[gabalafou]

jupyterlab/jupyterlab#13415

[gabalafou]

Update on this issue.

This issue stalled on the test-writing sub-task because I couldn't make the test that I wrote pass. I believe that Mark's PR fixed the issue, but I need to go back and try testing it.

[trallard]

@gabalafou can you remind me what we said about this particular issue, will you be working on it? are we pausing this?

[gabalafou]

This issue has 2 parts:

1. fix
2. regression test

The first part is done. The second part is still outstanding, and I plan to work on it in the upcoming weeks as part of my focus on accessibility testing in order to both integrate accessibility regression testing with general JupyterLab testing and to get ready for my talk at JupyterCon.

[gabalafou]

By the way, this is the PR that does the "fix" part of this issue (it just doesn't have a regression test yet):

• Make focus visible (mostly CSS) jupyterlab/jupyterlab#13415

[trallard]

Regression tests added - need more things fixed

[gabalafou]

I'm going to mark this as closed, even though there are some things that are still in progress:

• Focus visible (initial page) regression test is in review, it has not been merged yet
• Regression test fails because the skip link is broken (not visible), but there is a PR open to fix the skip link

I'm going to mark it as closed because the bulk of the work that I can do for this issue is already done.