From 2d4da24437944b19f6c8bc5c5b9a5d0b01c454ce Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Quang=20T=C3=B9ng?= <quangtung29121997@gmail.com>
Date: Mon, 8 Apr 2024 14:22:38 +0700
Subject: [PATCH] Fix Retry Watch & Global Events Order (#8)

* Fix Retry Watch & Global Events Order
---
 curator/fake_client.go      | 10 +++++--
 curator/fake_client_test.go | 59 +++++++++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+), 3 deletions(-)

diff --git a/curator/fake_client.go b/curator/fake_client.go
index 87b63ed..9e91d9f 100644
--- a/curator/fake_client.go
+++ b/curator/fake_client.go
@@ -517,13 +517,17 @@ func (s *FakeZookeeper) Retry(clientID FakeClientID) {
 	getActionWithType[RetryInput](s, clientID, "Retry")
 
 	state := s.States[clientID]
+
 	state.ConnErr = false
-	for _, fn := range state.PendingEvents {
-		fn()
-	}
+	pendingEvents := state.PendingEvents
 	state.PendingEvents = nil
+
 	runner := s.Sessions[clientID]
 	runner.Retry()
+
+	for _, fn := range pendingEvents {
+		fn()
+	}
 }
 
 type fakeClient struct {
diff --git a/curator/fake_client_test.go b/curator/fake_client_test.go
index db69c96..068d624 100644
--- a/curator/fake_client_test.go
+++ b/curator/fake_client_test.go
@@ -1326,3 +1326,62 @@ func TestFakeClient_Should_Not_Recv_Watch_After_Expired_For_ChildrenW(t *testing
 		"children-resp",
 	}, c.steps)
 }
+
+func TestFakeClient_Retry_Happens_Before_Watch_Handlers(t *testing.T) {
+	c := newFakeClientTest()
+
+	callback := func(client Client) {
+		client.Create("/worker", nil, zk.FlagEphemeral, func(resp zk.CreateResponse, err error) {
+		})
+	}
+
+	var getFunc func(sess *Session)
+	getFunc = func(sess *Session) {
+		sess.Run(func(client Client) {
+			c.addStep("get-req")
+			client.Get("/hello", func(resp zk.GetResponse, err error) {
+				c.addStep("get-resp")
+				if stderrors.Is(err, zk.ErrConnectionClosed) {
+					sess.AddRetry(getFunc)
+					return
+				}
+				if err != nil {
+					panic(err)
+				}
+			})
+		})
+	}
+
+	NewFakeClientFactory(c.store, client2).Start(New(func(sess *Session) {
+		sess.Run(func(client Client) {
+			client.ChildrenW("/", func(resp zk.ChildrenResponse, err error) {
+				c.addStep("children-resp")
+			}, func(ev zk.Event) {
+				c.addStep("children-watch")
+			})
+		})
+
+		getFunc(sess)
+	}))
+
+	c.startCuratorClient1(func(sess *Session) {
+		sess.Run(callback)
+	})
+
+	c.store.Begin(client1)
+	c.store.Begin(client2)
+
+	c.store.ChildrenApply(client2)
+	c.store.ConnError(client2)
+
+	c.store.CreateApply(client1)
+	c.store.Retry(client2)
+
+	assert.Equal(t, []string{
+		"get-req",
+		"children-resp",
+		"get-resp",
+		"get-req",
+		"children-watch",
+	}, c.steps)
+}