Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the vars() computation #12

Closed
haz opened this issue Jul 30, 2020 · 0 comments · Fixed by #17
Closed

Improve the vars() computation #12

haz opened this issue Jul 30, 2020 · 0 comments · Fixed by #17
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
0.3.0

Comments

@haz
Copy link
Collaborator

haz commented Jul 30, 2020

Currently, it traverses the entire structure with the walk function, but nothing is memoized. nnf.vars() is likely called often enough to warrant some improvement.
@haz haz added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 30, 2020
This was referenced Aug 2, 2020
Open
Merged
@haz haz added this to the 0.3.0 milestone Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Memoization and other optimizations and fixes QuMuLab/python-nnf
1 participant
@haz