Skip to content

Commit 5a2a3b3

Browse files
authored
Merge pull request #355 from shreesh-webkul/gli-773
Added upper limit of PHP version for QloApps installation
2 parents 990b1c0 + ae74a67 commit 5a2a3b3

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

classes/ConfigurationTest.php

+4-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,10 @@ public static function run($ptr, $arg = 0)
145145

146146
public static function test_phpversion()
147147
{
148-
return version_compare(substr(phpversion(), 0, 5), '5.6.0', '>=');
148+
return (
149+
version_compare(substr(phpversion(), 0, 5), '5.6.0', '>=')
150+
&& version_compare(substr(phpversion(), 0, 5), '8.0', '<')
151+
);
149152
}
150153

151154
public static function test_new_phpversion()

controllers/admin/AdminInformationController.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public function renderView()
108108
public function getTestResult()
109109
{
110110
$tests_errors = array(
111-
'phpversion' => $this->l('Update your PHP version.'),
111+
'phpversion' => $this->l('The required PHP version is between 5.6 to 7.4.'),
112112
'upload' => $this->l('Configure your server to allow file uploads.'),
113113
'system' => $this->l('Configure your server to allow the creation of directories and files with write permissions.'),
114114
'gd' => $this->l('Enable the GD library on your server.'),
@@ -128,7 +128,7 @@ public function getTestResult()
128128
'register_globals' => $this->l('Set PHP "register_globals" option to "Off".'),
129129
'gz' => $this->l('Enable GZIP compression on your server.'),
130130
'files' => $this->l('Some QloApps files are missing from your server.'),
131-
'new_phpversion' => sprintf($this->l('You are using PHP %s version. Soon, the latest PHP version supported by QloApps will be PHP 5.4. To make sure you’re ready for the future, we recommend you to upgrade to PHP 5.4 now!'), phpversion()),
131+
'new_phpversion' => sprintf($this->l('You are using PHP %s version. Soon, the latest PHP version supported by QloApps will be PHP 5.6. To make sure you’re ready for the future, we recommend you to upgrade to PHP 5.6 now!'), phpversion()),
132132
'pdo_mysql' => $this->l('PDO MySQL extension is not loaded'),
133133
'openssl' => $this->l('PHP OpenSSL extension is not loaded'),
134134
);

install/controllers/http/system.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public function display()
8787
'title' => $this->l('Required PHP parameters'),
8888
'success' => 1,
8989
'checks' => array(
90-
'phpversion' => $this->l('Minimum PHP 5.6.0 or later is required'),
90+
'phpversion' => $this->l('The required PHP version is between 5.6 to 7.4'),
9191
'upload' => $this->l('Cannot upload files'),
9292
'system' => $this->l('Cannot create new files and folders'),
9393
'gd' => $this->l('GD library is not installed'),

0 commit comments

Comments
 (0)