Skip to content

Removes old VarQTE algorithm code (without primitives).#8750

Merged
mergify[bot] merged 5 commits into
Qiskit:mainfrom
dlasecki:varqte-removal
Sep 15, 2022
Merged

Removes old VarQTE algorithm code (without primitives).#8750
mergify[bot] merged 5 commits into
Qiskit:mainfrom
dlasecki:varqte-removal

Conversation

@dlasecki
Copy link
Copy Markdown
Contributor

Summary

Removes old VarQTE algorithm code (without primitives).

Details and comments

No deprecation needed as the code has never been released.

@qiskit-bot
Copy link
Copy Markdown
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@dlasecki dlasecki added this to the 0.22 milestone Sep 14, 2022
@woodsp-ibm
Copy link
Copy Markdown
Member

This will also need to remove the imports and doc changes that refer to these additions from the algorithms.__init__.py file, I imagine that is most likely causing the issues here

@dlasecki
Copy link
Copy Markdown
Contributor Author

This will also need to remove the imports and doc changes that refer to these additions from the algorithms.__init__.py file, I imagine that is most likely causing the issues here

Sure! Thanks for reminding. Was in a bit of a hurry.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 15, 2022

Pull Request Test Coverage Report for Build 3058694165

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 167 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.04%) to 84.386%

Files with Coverage Reduction New Missed Lines %
qiskit/algorithms/evolvers/imaginary_evolver.py 1 83.33%
qiskit/pulse/instructions/play.py 1 97.37%
qiskit/pulse/transforms/canonicalization.py 1 92.35%
qiskit/algorithms/optimizers/snobfit.py 2 92.11%
qiskit/namespace.py 2 91.67%
qiskit/opflow/gradients/derivative_base.py 2 91.57%
qiskit/pulse/instructions/snapshot.py 2 93.55%
qiskit/pulse/parameter_manager.py 2 90.42%
qiskit/primitives/sampler.py 4 94.94%
qiskit/pulse/instructions/acquire.py 5 89.36%
Totals Coverage Status
Change from base Build 3053075546: 0.04%
Covered Lines: 59084
Relevant Lines: 70016

💛 - Coveralls

@woodsp-ibm woodsp-ibm added Changelog: None Do not include in the GitHub Release changelog. automerge labels Sep 15, 2022
@mergify mergify Bot merged commit 8bb1c01 into Qiskit:main Sep 15, 2022
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
* Removed old VarQTE and tests.

* Removed reno

* Updated init.

* Updated init.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
…t#8750)

* Removed old VarQTE and tests.

* Removed reno

* Updated init.

* Updated init.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants