Rename (Minimum)EigensolverResult.aux_operator_eigenvalues from "eigenvalues" to just "values"

[Cryoris]

Summary

The eigensolver algorithms allow the evaluation of the expectation value of auxiliary operators at the final optimal point. These expectation values are generally not the eigenvalue of the auxiliary operators. However we currently store these expectations in an attribute called aux_operator_eigenvalues which is a bit misleading. This commit renames the attribute to just aux_operator_values to reflect that it's not an eigenvalue.

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core
• @manoelmarques
• @woodsp-ibm

[coveralls]

Pull Request Test Coverage Report for Build 2308497351

• 39 of 39 (100.0%) changed or added relevant lines in 6 files are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.004%) to 84.381%

---

Files with Coverage Reduction	New Missed Lines	%
qiskit/utils/deprecation.py	4	85.19%

Totals
Change from base Build 2307415935:	0.004%
Covered Lines:	54515
Relevant Lines:	64606

---

💛 - Coveralls

[Cryoris]

This has been addressed by #8702 where the result has been renamed to aux_operators_evaluated 🙂