ResourceEstimation AnalysisPass#1889
Merged
Merged
Conversation
1ucian0
requested review from
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
mtreinish,
nonhermitian and
taalexander
as code owners
Member
|
Can you name the pass "ResourceEstimation" in line with the literature? Also this needs to include all resources: size, depth, width, etc.. They are listed as methods on the QuantumCircuit object and you can pull them from there. I think each can go as a separate entry into the property_set. Just name them what the property is, Can you also add a CHANGELOG. |
Contributor
|
Can this also count swaps, so we know how many a mapper adds? |
Member
Author
|
in the process if adding |
ajavadia
changed the title
ajavadia
requested changes
Mar 11, 2019
Member
|
can you add a changelog. |
ajavadia
reviewed
Apr 4, 2019
ajavadia
reviewed
Apr 4, 2019
Co-Authored-By: 1ucian0 <luciano@debian.org>
Co-Authored-By: 1ucian0 <luciano@debian.org>
Co-Authored-By: 1ucian0 <luciano@debian.org>
Co-Authored-By: 1ucian0 <luciano@debian.org>
Co-Authored-By: 1ucian0 <luciano@debian.org>
Co-Authored-By: 1ucian0 <luciano@debian.org>
Co-Authored-By: 1ucian0 <luciano@debian.org>
Co-Authored-By: 1ucian0 <luciano@debian.org>
Co-Authored-By: 1ucian0 <luciano@debian.org>
ajavadia
approved these changes
Apr 4, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* count operations pass * empty dag test * rename * test * test rename * test name * Update qiskit/transpiler/passes/resource_estimation.py Co-Authored-By: 1ucian0 <luciano@debian.org> * count_ops * count_ops * lint * changelog * depth pass * size pass * size pass * count_ops pass * size pass * NumTensorFactor pass * resource calculation metapass * lint * unused import * changelog * lint * Update qiskit/transpiler/passes/__init__.py Co-Authored-By: 1ucian0 <luciano@debian.org> * Update qiskit/transpiler/passes/width.py Co-Authored-By: 1ucian0 <luciano@debian.org> * Update qiskit/transpiler/passes/num_tensor_factor.py Co-Authored-By: 1ucian0 <luciano@debian.org> * Update qiskit/transpiler/passes/depth.py Co-Authored-By: 1ucian0 <luciano@debian.org> * Update qiskit/transpiler/passes/depth.py Co-Authored-By: 1ucian0 <luciano@debian.org> * Update qiskit/transpiler/passes/size.py Co-Authored-By: 1ucian0 <luciano@debian.org> * Update qiskit/transpiler/passes/width.py Co-Authored-By: 1ucian0 <luciano@debian.org> * Update qiskit/transpiler/passes/size.py Co-Authored-By: 1ucian0 <luciano@debian.org> * Update qiskit/transpiler/passes/num_tensor_factor.py Co-Authored-By: 1ucian0 <luciano@debian.org> * renaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pass to count operations, useful to fix point analysis when optimizing.