Remove print calls from test suite#11253
Merged
Merged
Conversation
This removes some debugging `print` statements from the test suite, to avoid noise in the test-runner output. In some cases, the `print` was only part of an assertion that the conversion to string fails, and these were converted to explicit calls to `str`. This isn't strictly necessary, it's just trying to get the test suite out of the habit of using `print`.
jakelishman
added
type: qa
jakelishman
requested review from
a team,
ikkoham and
t-imamichi
as code owners
Collaborator
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6880444469
💛 - Coveralls |
mtreinish
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes some debugging
printstatements from the test suite, to avoid noise in the test-runner output. In some cases, theprintwas only part of an assertion that the conversion to string fails, and these were converted to explicit calls tostr. This isn't strictly necessary, it's just trying to get the test suite out of the habit of usingprint.Details and comments