Skip to content

Draft: Improve performance of QuantumCircuit.measure_all and QuantumCircuit.barrier by using _append fast path #11008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eendebakpt wants to merge 2 commits into from
Closed

Draft: Improve performance of QuantumCircuit.measure_all and QuantumCircuit.barrier by using _append fast path #11008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
610d3fe
Improve performance of QuantumCircuit.measure_all and QuantumCircuit.…
eendebakpt Oct 12, 2023
72169e2
fix case of custom arguments
eendebakpt Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions qiskit/circuit/quantumcircuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2312,15 +2312,15 @@ def measure_all(
new_creg = circ._create_creg(len(circ.qubits), "meas")
circ.add_register(new_creg)
circ.barrier()
circ.measure(circ.qubits, new_creg)
self._append(Measure(), circ.qubits, new_creg)
else:
if len(circ.clbits) < len(circ.qubits):
raise CircuitError(
"The number of classical bits must be equal or greater than "
"the number of qubits."
)
circ.barrier()
circ.measure(circ.qubits, circ.clbits[0 : len(circ.qubits)])
self._append(Measure(), circ.qubits, circ.clbits[0 : len(circ.qubits)])

if not inplace:
return circ
Expand Down Expand Up @@ -2848,11 +2848,11 @@ def barrier(self, *qargs: QubitSpecifier, label=None) -> InstructionSet:
"""
from .barrier import Barrier

qubits: list[QubitSpecifier] = []

if not qargs: # None
qubits.extend(self.qubits)
self._append(Barrier(len(self.qubits), label=label), self.qubits, [])

qubits: list[QubitSpecifier] = []
for qarg in qargs:
if isinstance(qarg, QuantumRegister):
qubits.extend([qarg[j] for j in range(qarg.size)])
Expand Down