Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PassManager.passes() needs a drawer #2317

Closed
1ucian0 opened this issue May 5, 2019 · 3 comments · Fixed by #2445
Closed

PassManager.passes() needs a drawer #2317

1ucian0 opened this issue May 5, 2019 · 3 comments · Fixed by #2445
Assignees
Labels
good first issue Good for newcomers

Comments

@1ucian0
Copy link
Member

1ucian0 commented May 5, 2019

For context, originally posted by @jaygambetta in #2179 (comment)

I also think I should be able to draw a pass manager

pm.draw()

and it make a flow diagram of all the passes I have in my pass manager with the inputs going into them

Via #2079, PassManager.passes() returns structure with the passes and flow control in a pass manager instance. A drawer should take that structure and make flow diagram based on it.

@1ucian0 1ucian0 added the good first issue Good for newcomers label May 5, 2019
@maddy-tod
Copy link
Contributor

I'm happy to do this if no one has started on it already? Are there any further ideas about what this should look like?

@1ucian0
Copy link
Member Author

1ucian0 commented May 15, 2019

I was thinking in something like a flow chart in graphviz (we use it already for drawing the dag)... Let me know if you have questions about the PassManager.passes() structure.

@ajavadia
Copy link
Member

I think the thing to show would be that blocks of multiple passes can have a "control" (do-while) and/or a "condition" (if). Otherwise just drawing each pass in a box, and showing the input parameters of the pass, seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants