From 9b03c897074c82a781cabdf1801719b23a706e72 Mon Sep 17 00:00:00 2001 From: kevin-tian Date: Thu, 21 Sep 2023 14:40:30 -0400 Subject: [PATCH 1/3] Attempt to fix terra unit tests --- test/unit/test_data_serialization.py | 4 ++-- test/unit/test_sampler.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/unit/test_data_serialization.py b/test/unit/test_data_serialization.py index f4845e55ef..8aa8cd42f7 100644 --- a/test/unit/test_data_serialization.py +++ b/test/unit/test_data_serialization.py @@ -80,8 +80,8 @@ def test_coder(self): def test_coder_qc(self): """Test runtime encoder and decoder for circuits.""" bell = ReferenceCircuits.bell() - unbound = EfficientSU2(num_qubits=4, reps=1, entanglement="linear") - subtests = (bell, unbound, [bell, unbound]) + unbound = EfficientSU2(3, reps=1) + subtests = (bell, unbound) for circ in subtests: with self.subTest(circ=circ): encoded = json.dumps(circ, cls=RuntimeEncoder) diff --git a/test/unit/test_sampler.py b/test/unit/test_sampler.py index 02d5a6fbe7..9c9a95bd2c 100644 --- a/test/unit/test_sampler.py +++ b/test/unit/test_sampler.py @@ -12,7 +12,7 @@ """Tests for sampler class.""" -from qiskit.circuit import QuantumCircuit +from qiskit.test.reference_circuits import ReferenceCircuits from qiskit_ibm_runtime import Sampler, Session from ..ibm_test_case import IBMTestCase @@ -32,7 +32,7 @@ def test_unsupported_values_for_sampler_options(self): service=FakeRuntimeService(channel="ibm_quantum", token="abc"), backend="common_backend", ) as session: - circuit = QuantumCircuit(1, 1) + circuit = ReferenceCircuits.bell() for bad_opt in options_bad: inst = Sampler(session=session) with self.assertRaises(ValueError) as exc: From 57d55e2e132603b637992945b1eead0349719192 Mon Sep 17 00:00:00 2001 From: kevin-tian Date: Thu, 21 Sep 2023 14:44:53 -0400 Subject: [PATCH 2/3] test on my fork --- .github/workflows/unit-tests-terra-main.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/unit-tests-terra-main.yml b/.github/workflows/unit-tests-terra-main.yml index 20f99bcb15..5a04d96659 100644 --- a/.github/workflows/unit-tests-terra-main.yml +++ b/.github/workflows/unit-tests-terra-main.yml @@ -13,11 +13,10 @@ name: Unit Tests on: schedule: - - cron: '0 5 * * *' + - cron: "0 5 * * *" workflow_dispatch: jobs: unit-tests-latest-qiskit-terra: - if: github.repository_owner == 'Qiskit' name: Run unit tests with latest code of qiskit-terra runs-on: "ubuntu-latest" env: @@ -41,4 +40,4 @@ jobs: - name: Run tests # running unit tests against latest (non-released) code of qiskit-terra gives a basic level # of confidence that the integration between qiskit-ibm-runtime and qiskit-terra works - run: make unit-test \ No newline at end of file + run: make unit-test From fe69f72a2b4e7f781851df6968727eea7da84d40 Mon Sep 17 00:00:00 2001 From: kevin-tian Date: Thu, 21 Sep 2023 15:25:22 -0400 Subject: [PATCH 3/3] revert coder_qc change --- .github/workflows/unit-tests-terra-main.yml | 5 +++-- test/unit/test_data_serialization.py | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/unit-tests-terra-main.yml b/.github/workflows/unit-tests-terra-main.yml index 5a04d96659..20f99bcb15 100644 --- a/.github/workflows/unit-tests-terra-main.yml +++ b/.github/workflows/unit-tests-terra-main.yml @@ -13,10 +13,11 @@ name: Unit Tests on: schedule: - - cron: "0 5 * * *" + - cron: '0 5 * * *' workflow_dispatch: jobs: unit-tests-latest-qiskit-terra: + if: github.repository_owner == 'Qiskit' name: Run unit tests with latest code of qiskit-terra runs-on: "ubuntu-latest" env: @@ -40,4 +41,4 @@ jobs: - name: Run tests # running unit tests against latest (non-released) code of qiskit-terra gives a basic level # of confidence that the integration between qiskit-ibm-runtime and qiskit-terra works - run: make unit-test + run: make unit-test \ No newline at end of file diff --git a/test/unit/test_data_serialization.py b/test/unit/test_data_serialization.py index 8aa8cd42f7..f4845e55ef 100644 --- a/test/unit/test_data_serialization.py +++ b/test/unit/test_data_serialization.py @@ -80,8 +80,8 @@ def test_coder(self): def test_coder_qc(self): """Test runtime encoder and decoder for circuits.""" bell = ReferenceCircuits.bell() - unbound = EfficientSU2(3, reps=1) - subtests = (bell, unbound) + unbound = EfficientSU2(num_qubits=4, reps=1, entanglement="linear") + subtests = (bell, unbound, [bell, unbound]) for circ in subtests: with self.subTest(circ=circ): encoded = json.dumps(circ, cls=RuntimeEncoder)