From f94394fd6e4d90a62b3d0aa23d62a5cf7c337100 Mon Sep 17 00:00:00 2001 From: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com> Date: Wed, 28 Feb 2024 15:53:55 -0500 Subject: [PATCH] Fix bad tox.ini passenv setting (#825) Fixes https://github.com/Qiskit/qiskit-ibm-provider/pull/821. I made a divergence from our testing in qiskit-sphinx-theme to make the INI file more readable, and I didn't properly test it. My bad! This bug meant that we always used `main` as the branch name. I tested this out locally and it works now: ``` GITHUB_REF_NAME="pull" GITHUB_BASE_REF="upstream" tox -e docs ... raise ValueError(GITHUB_BRANCH) ValueError: upstream ``` --- tox.ini | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tox.ini b/tox.ini index b602c4f0..240b8364 100644 --- a/tox.ini +++ b/tox.ini @@ -10,8 +10,8 @@ setenv = VIRTUAL_ENV={envdir} LANGUAGE=en_US LC_ALL=en_US.utf-8 -passenv= - GITHUB_REF_NAME, +passenv = + GITHUB_REF_NAME GITHUB_BASE_REF commands = python -m unittest -v