From ea94dd6271e38820606195d33df2df8e752d80d3 Mon Sep 17 00:00:00 2001 From: merav-aharoni Date: Tue, 5 Sep 2023 12:20:29 +0000 Subject: [PATCH 1/2] Moved here from qiskit-ibm-runtime --- test/unit/test_utils_converters.py | 47 ++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 test/unit/test_utils_converters.py diff --git a/test/unit/test_utils_converters.py b/test/unit/test_utils_converters.py new file mode 100644 index 000000000..e9948b934 --- /dev/null +++ b/test/unit/test_utils_converters.py @@ -0,0 +1,47 @@ +# This code is part of Qiskit. +# +# (C) Copyright IBM 2022. +# +# This code is licensed under the Apache License, Version 2.0. You may +# obtain a copy of this license in the LICENSE.txt file in the root directory +# of this source tree or at http://www.apache.org/licenses/LICENSE-2.0. +# +# Any modifications or derivative works of this code must retain this +# copyright notice, and modified files need to carry a notice indicating +# that they have been altered from the originals. + +"""Tests for the methods utils.converters file.""" + +from qiskit_ibm_runtime.exceptions import IBMInputValueError +from qiskit_ibm_runtime.utils.converters import hms_to_seconds +from ..ibm_test_case import IBMTestCase + + +class TestUtilsConverters(IBMTestCase): + """Tests for the methods utils.converters file.""" + + def test_hms_to_seconds(self): + """Test converting hours minutes seconds (string) to seconds (int).""" + valid_strings = [ + ("2h", 7200), + ("50m", 3000), + ("20s", 20), + ("1h 30m", 5400), + ("3h 30m 30s", 12630), + ("3h 30s", 10830), + ("3h30m30s", 12630), + ] + invalid_strings = [ + "2d", + "24h", + "60m", + "60s", + "2w", + ] + for valid_string in valid_strings: + with self.subTest(valid_string=valid_string): + self.assertEqual(hms_to_seconds(valid_string[0]), valid_string[1]) + for invalid_string in invalid_strings: + with self.subTest(invalid_string=invalid_string): + with self.assertRaises(IBMInputValueError): + hms_to_seconds(invalid_string) From 9e798a719848d0265fb82ce16ff8ff7b1479c4ae Mon Sep 17 00:00:00 2001 From: merav-aharoni Date: Tue, 5 Sep 2023 15:39:38 +0000 Subject: [PATCH 2/2] Fixed imports --- test/unit/test_utils_converters.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/unit/test_utils_converters.py b/test/unit/test_utils_converters.py index e9948b934..ebb495555 100644 --- a/test/unit/test_utils_converters.py +++ b/test/unit/test_utils_converters.py @@ -12,8 +12,8 @@ """Tests for the methods utils.converters file.""" -from qiskit_ibm_runtime.exceptions import IBMInputValueError -from qiskit_ibm_runtime.utils.converters import hms_to_seconds +from qiskit_ibm_provider.exceptions import IBMInputValueError +from qiskit_ibm_provider.utils.converters import hms_to_seconds from ..ibm_test_case import IBMTestCase