Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up usage of the phrases Pivotal and Pivotal Web Services #248

Open
norman-abramovitz opened this issue Jul 24, 2021 · 4 comments
Open

Comments

@norman-abramovitz
Copy link
Contributor

With Pivotal now subsumed by VMWare and Pivotal Web Services not existing anymore, these phrases should be updated.

The word pivotal exists in the following files and should be reviewed.

README.md
ci/pipeline-test-lessons.yml
ci/pipeline.yml
docs/basics/pipeline-resources.md
docs/miscellaneous/yaml-editors.md
docs/miscellaneous/run-tests-before-deploy.md
docs/index.md

@JasonTheMain
Copy link

Hello Norm, after review of the usages of pivotal. It seems that the only reference to them outside of valid links or API references is in the acknowledgment for sponsorship on the readme and index. I don't believe there is a need for a change at this point.
Thank you

@norman-abramovitz
Copy link
Contributor Author

Not exactly correct. Some areas have been corrected already but the file docs/miscellaneous/run-tests-before-deploy.md needs to be modified since the pivotal web services does not exist anymore and the credhub example will not run correctly. This example needs to be changed or rewritten.

@norman-abramovitz
Copy link
Contributor Author

We might want to include some more information about other yaml editors as well.

@JasonTheMain
Copy link

Okay, I'll work on updating docs/miscellaneous/run-tests-before-deploy.md with an alternative and add some information for more yaml editors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants