Changes to issuance_txid_digest to align with ZIP 244#7
Merged
Conversation
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vivek-arte
force-pushed
the
digest_changes
branch
from
75dfbe3 to
8351cde
Compare
PaulLaux
approved these changes
Mar 13, 2023
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Overall good, added minor comments.
Comment on lines
300
to
301
| ├── issue_actions_digest | ||
| └── issuerVerificationKey |
There was a problem hiding this comment.
They both should have the same case: issue_actions or issueActions not both.
Author
There was a problem hiding this comment.
The naming convention in ZIP 244 is at the bottom of this section -- camelCase if it is not a hash of something else, snake_case if it is a BLAKE2b hash.
I see an inconsistency in the use of both issuerVerificationKey and issuanceValidatingKey which I am now fixing.
Comment on lines
+309
to
+310
| T.1: issue_actions_digest (32-byte hash output) | ||
| T.2: issuanceValidatingKey (32 bytes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.